Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude files in production #29

Merged
merged 1 commit into from
Mar 15, 2018
Merged

Exclude files in production #29

merged 1 commit into from
Mar 15, 2018

Conversation

vinkla
Copy link
Contributor

@vinkla vinkla commented Mar 15, 2018

This pull request excludes even more files which we don't need in production.

https://www.reddit.com/r/PHP/comments/2jzp6k/i_dont_need_your_tests_in_my_production/

This pull request excludes even more files which we don't need in production.

https://www.reddit.com/r/PHP/comments/2jzp6k/i_dont_need_your_tests_in_my_production/
@staabm staabm merged commit 1a89485 into sabre-io:master Mar 15, 2018
@staabm
Copy link
Member

staabm commented Mar 15, 2018

Thx

@DominikTo
Copy link
Member

I have no strong opinion about this, but it seems like the benefits are quite small - we save a few kilobytes.

But there seem to be some good arguments about drawbacks:

See e.g.:
symfony/symfony#6605

So, should we really do this?

@phil-davis
Copy link
Contributor

This is "a good thing" in general. But note that the unit tests from here were being run in sabre-io/dav - the tests/phpunit.xml there had:

      <testsuite name="sabre-uir">
          <directory>../vendor/sabre/uri/tests/</directory>
      </testsuite>

But actually no tests appear there any more. So actually those tests have not been running in sabre-io/dav CI.

A new version of phpunit is now reporting when there is a test suite defined that does not exist. CI started failing in sabre-io/dav. See sabre-io/dav#1316

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants