Target 2.13 #3
Closed
Target 2.13 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GraphQLVisitorSpec depends on the Sangria AST which hasn't been published for Scala 2.13 yet. Rather than removing the tests keep them around for 2.11 and 2.12 until a permanent solution can be found (either by publishing a compatible version of Sangria or rewriting the tests).
jtjeferreira
approved these changes
Jul 17, 2019
|
👍, is there anything I can do to help with this? |
I think they are still trying to obtain the commit rights |
|
Included in sangria-graphql-org#1, so this can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare Sangria for 2.13 by targeting
macro-visitfor 2.13 as well. This shouldn't be a breaking change (wrt to binary compability) so it should be possible to publish this as 0.1.1.