Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving forward with Sangria #446

Closed
yanns opened this issue May 10, 2019 · 65 comments
Closed

Moving forward with Sangria #446

yanns opened this issue May 10, 2019 · 65 comments

Comments

@yanns
Copy link
Contributor

yanns commented May 10, 2019

Please read the following before: #445

With great sadness, the Sangria community will have to organize itself and continue development without Oleg Ilyenko in the future.
This thread exists to discuss how to move forward after we’ve processed the sad news. There is no reason to rush this, please take your time.
We at commercetools, where Oleg has worked since 2013, are using Sangria extensively and are invested in its future.

Let's open the discussion on how to maintain Sangria in the future.

@yasserkaddour
Copy link
Member

I am the only remaining member in sangria-graphql organization, unfortunately I only have write access for 2 repos https://github.com/sangria-graphql/sangria-playground and https://github.com/sangria-graphql/sangria-relay-playground . Your colleague @cneijenhuis told me he already contacted GitHub on how to regain full access to the organization and apparently it's a lengthy process. I would be happy to help appoint worthy maintainers for Sangria to continue the work, like Oleg would have liked.

@yanns
Copy link
Contributor Author

yanns commented May 17, 2019

For information, we are in contact with Github to check if we can gain write access to the whole organization and the related projects.
I'll keep you informed.

@yanns
Copy link
Contributor Author

yanns commented May 17, 2019

I guess there are other parts we have to check:

  • DNS: sangria-graphql.org (https://whois.icann.org/en/lookup?name=sangria-graphql.org)
  • rights to push new release (sonatype / maven):

    sangria/build.sbt

    Lines 59 to 66 in 65ffe26

    publishMavenStyle := true
    publishArtifact in Test := false
    pomIncludeRepository := (_ false)
    publishTo := Some(
    if (isSnapshot.value)
    "snapshots" at "https://oss.sonatype.org/content/repositories/snapshots"
    else
    "releases" at "https://oss.sonatype.org/service/local/staging/deploy/maven2")

Is there something else?

@dave-handy
Copy link

dave-handy commented May 22, 2019

@yanns do you know anything about the "scaldi" org and projects? I don't think these are nearly as popular or active as sangria, but they do need some basic care and feeding to keep up with dependency and scala language updates. My (small) company is heavily invested in the scaldi core library, with great success, and might be willing to take on some of the responsibility.

Any tips? I am thinking about making a similar issue to this one in the scaldi repo and see if someone chimes in with helpful information. However I'm not expecting much in response since it is much less active.

I'm assuming Oleg developed scaldi during his tenure at your company, but you don't use it there any longer?

@yanns
Copy link
Contributor Author

yanns commented May 22, 2019

@dave-handy we are in the process of having all rights on all projects, included scaldi.
This is the first step.
In a second step, I'd like to make a call for people who are willing to maintain those, and give them enough rights to do so.

You can open a similar issue on scaldi. If you already volunteer to maintain the project, please mention it also.(it'd be very welcome ❤️ )

@vmandrychenko
Copy link

Hello everyone,

We (Garner) don't have the resources to maintain the sangria repo full time but we will certainly contribute with PRs, new features, bug fixes and an increase of the code coverage, especially if it aligns with our feature/bugfix road map.

@paulpdaniels
Copy link
Contributor

I know the team at LeadIQ would very much like to contribute to Sangria's continued success. I personally would be interested in helping maintaining Sangria, but I'm not sure how much use I would be since I haven't ever really messed with the internals of the library itself.

Perhaps we could start by going down the list of top contributors and seeing if they would be interested in being a co-maintainer? Then we can start refining the contribution process from there?

@anagrius
Copy link
Contributor

We Humio are also very invested in Sangria and would like to help out as possible.

@jregistr
Copy link

jregistr commented Jun 23, 2019

Not sure if this has ever been raised in the history of Sangria, but could Scala Center or Lightbend be the folks we are looking for? It's looking so far that even though we have many contributors, we still lack a someone with the resources to be maintainer. With Sangria being THE GraphQl implementation in Scala, it'd make sense for one of these large organizations to lead it. Or is that not how that works?

@dave-handy
Copy link

@yanns has there been any progress on getting the needed permissions? I see that there hasn't been any new commits in sangria master either.

@yanns
Copy link
Contributor Author

yanns commented Jul 26, 2019

Some news:

  • we opened on ticket on github to gain the rights as they asked
  • after several weeks of silence, they finally answered us, and it's more complicated than what they initially told us 🙄
  • we may need more papers from the family

So we'll try that and keep you in touch.
But all in all, github is not very cooperative on that and making everything complex.

@dave-handy
Copy link

Thanks for the update! Protenus may start a fork of scaldi if we decide to start our scala 2.13 process soon.

@siderakis
Copy link

I started hacking around with the idea of converting a schema created using Sangria to a GraphQL-Java schema. The end result would be similar to kotlin-graphql.

For me this seems like a fine option but I'm wondering what others think. I'm a little biased because I work on rejoiner.io which is also based on GraphQL-Java.

@travisbrown
Copy link
Contributor

@yanns Is there anything any of us can do to help with this process?

@yanns
Copy link
Contributor Author

yanns commented Aug 8, 2019

@travisbrown If you know some intern at github, maybe this person could help our case.
Otherwise I still have to take the time to prepare new papers with the family.

@schrepfler
Copy link
Contributor

I’ve pinged Nat Friedman on Twitter if they can take a look. https://twitter.com/schrepfler/status/1159262893919145984?s=21

@TJSomething
Copy link

Would it make sense to do work on a temporary fork while the process is being worked out?

@travisbrown
Copy link
Contributor

@TJSomething Publishing to Maven Central via Sonatype also depends on access to the GitHub organization (although it's possible that @yasserkaddour could get verified now via sangria-playground).

There is ongoing work happening in forks (I'm personally testing local builds for Scala 2.13 now, for example). I'm not a core maintainer, but my own feeling is that the overhead of switching to a temporary "official" fork would be substantial, and we should avoid it if we can, even if it means waiting a little longer for new official releases.

@nickhudkins
Copy link
Contributor

Hi @yanns anything we can do to help out?

@yanns
Copy link
Contributor Author

yanns commented Sep 5, 2019

@nickhudkins not that I'm aware of, unless you know someone at Github who can help us here.
I send them a document, and I'm still waiting for their answer...

@nickhudkins
Copy link
Contributor

Thanks @yanns, I reached out to some folks on twitter in hopes of moving this along, and at least have a party willing to help. I am happy to do the leg work to help you out if you need anything, including just sending emails and talking to people :). Hopefully we can keep Oleg's work alive and well right here in the sangria-graphql org.

@nickhudkins
Copy link
Contributor

We may have an answer sooner thanks to: https://twitter.com/TwitterOSS/status/1171190354642497537 ?

@DEGoodmanWilson
Copy link

@yanns GitHub employee here, although not one in a direct position to help. Can you shoot me an email [email protected] ?

@mjadczak
Copy link

mjadczak commented Oct 8, 2019

Given that this has now been a pending issue for nearly 5 months, with no resolution seemingly in sight, should there now be a serious conversation about how long we are prepared to wait for the bureaucratic machine to grind through this issue, and at what point setting up an "official" fork (temporary or otherwise) should be considered?

@synedu
Copy link

synedu commented Oct 9, 2019

There is ongoing work happening in forks (I'm personally testing local builds for Scala 2.13 now, for example). I'm not a core maintainer, but my own feeling is that the overhead of switching to a temporary "official" fork would be substantial, and we should avoid it if we can, even if it means waiting a little longer for new official releases.

Do you still feel this way, @travisbrown ?

I agree with @mjadczak that the uncertainty needs to be addressed. Was there any update from github after the documentation they requested, @yanns ?

I think we all agree that sangria is an important and popular project in dire need of maintenance. The longer this issue remains unresolved, the more people will turn away from this library, to the detriment of the community.

@jregistr proposed new custodianship of sangria in June, although it doesn't appear that Scala Center or Lightbend have expressed an interest in doing so. It seems that the largest corporate user of sangria, and therefore the most resourced to maintain it, is twitter. Would it make sense to propose an official twitter fork and direct community efforts there? With twitter OSS behind it, the project would probably be more actively maintained and widely adopted.

@yanns
Copy link
Contributor Author

yanns commented Oct 9, 2019

There is ongoing work happening in forks (I'm personally testing local builds for Scala 2.13 now, for example). I'm not a core maintainer, but my own feeling is that the overhead of switching to a temporary "official" fork would be substantial, and we should avoid it if we can, even if it means waiting a little longer for new official releases.

Do you still feel this way, @travisbrown ?

I agree with @mjadczak that the uncertainty needs to be addressed. Was there any update from github after the documentation they requested, @yanns ?

Yes we provided the documentation they requested.
After some time without news, I asked them about the status, and they answered that they need more documentation.

Github is not really helping here. Every time we provide something, they ask for something more. 😢

So we have to ask the mother, one more time...
To be honest, we are feeling demotivated by the lack of any progress compared to the amount of time / energy we put into it.

If an organization or someone is ready to have an official fork, I'd also be ready to help.

@zvuki
Copy link

zvuki commented Apr 27, 2020

@yanns great news! Do you mind sharing the ownership with someone, you know, just in case?
p.s. I wish you good health.

@yanns
Copy link
Contributor Author

yanns commented Apr 27, 2020

@yanns great news! Do you mind sharing the ownership with someone, you know, just in case?
p.s. I wish you good health.

of course. We have to avoid being a single point of failure.
And I'll need help maintaining all the repositories.

yanns added a commit to yanns/repos that referenced this issue Apr 28, 2020
@travisbrown
Copy link
Contributor

Wow, this is great news, @yanns!

@yanns
Copy link
Contributor Author

yanns commented Apr 28, 2020

update:
I've replayed all changes made on the temp organization to this one

In the short term, I'd like to add at least one other owner to be on the safe side.
Any volunteer?

@travisbrown
Copy link
Contributor

@yanns I probably won't have much time to help with maintenance in the immediate future, but I'd be happy to join as a backup (and I already have org.sangria-graphql publishing rights on Sonatype).

@yanns
Copy link
Contributor Author

yanns commented Apr 28, 2020

@yanns I probably won't have much time to help with maintenance in the immediate future, but I'd be happy to join as a backup (and I already have org.sangria-graphql publishing rights on Sonatype).

Thanks you very much for proposing. I added you as backup.
Now the project is quite safe from this perspective.

@sachee
Copy link

sachee commented Apr 28, 2020

@yanns let me know if we (Twitter) can be of any help here. We have time set aside to help if you need it.

@yanns
Copy link
Contributor Author

yanns commented May 3, 2020

For the moment, I'm maintaining the sangria ecosystem with minimal time investment.

I'm not pushing sangria forward, like checking for new GraphQL features and implementing them.
I don't spent much time on opened issues.
I review PR as they come.

I will not be able to spend more time on it.

I think there are different kind of help I'd need:

  • someone taking care of the website. I don't know how the website is published. I don't know if Oleg bought the domain, for how long...
  • some people motivated to push sangria forwards, invested in the GraphQL community as well, checking for new features on the GraphQL side...
  • some people fixing open issues
  • some people checking for open issues, reviewing pull requests...

I think checking the website is a top priority to avoid losing the domain.

@astolzenberger
Copy link

Regarding the domain sangria-graphql.org

Updated Date: 2018-09-25T18:52:13Z
Creation Date: 2015-07-28T21:48:18Z
Registry Expiry Date: 2020-07-28T21:48:18Z

@virtualirfan
Copy link

Just reserved sangria-graphql.dev and sangria-graphql.com in case those are needed.

@mikulskibartosz
Copy link

Hi, is there an open issue that would be a good starting point for someone who has not contributed to that project yet?

@yanns
Copy link
Contributor Author

yanns commented May 4, 2020

Hi, is there an open issue that would be a good starting point for someone who has not contributed to that project yet?

not that I'm aware of. I won't have the time to do that.

@sachee
Copy link

sachee commented May 15, 2020

Hey @yanns thanks for all the info.

Twitter has headcount to help out with PRs, fixing issues, etc. Will we need any special permissions to contribute/review PRs?

@yanns
Copy link
Contributor Author

yanns commented May 19, 2020

@sachee Thanks for proposing! Very much appreciated.
I've created a team that has write access to all repositories: https://github.com/orgs/sangria-graphql/teams/contributors

We can discuss there who I should add.

@sachee
Copy link

sachee commented May 26, 2020

hey @yanns I get a 404 from the link you posted, do you have another link?

@yanns
Copy link
Contributor Author

yanns commented May 26, 2020

hey @yanns I get a 404 from the link you posted, do you have another link?

Maybe the link is only accessible to team members?
We can try another way: can you mention the people I should add to the contributors?

@sachee
Copy link

sachee commented Jun 9, 2020

Hey @yanns! Here are the Twitter folks who would be interested in contributing:
@lostplan
@nicky-isaacs
@mgadda
myself (@sachee)

@yanns
Copy link
Contributor Author

yanns commented Jun 10, 2020

Hey @yanns! Here are the Twitter folks who would be interested in contributing:
@lostplan
@nicky-isaacs
@mgadda
myself (@sachee)

💯
You are all invited to the "contributors" team

@yanns
Copy link
Contributor Author

yanns commented Jun 24, 2020

About the DNS domain: sangria-graphql/sangria-graphql.github.io#74

@Crisp3333
Copy link

Hello, I would love to help contribute if needed that is. I depend on Sangria a lot for work.

@yanns
Copy link
Contributor Author

yanns commented Aug 7, 2020

Hello, I would love to help contribute if needed that is. I depend on Sangria a lot for work.

Great to hear!
do you already have an idea?
If not, you can start looking at existing PR and/or issues, reviewing them.
sangria-graphql/sangria-graphql.github.io#74 is also an issue that one should take care of.

@Crisp3333
Copy link

Not much idea, but I will take your advise and look into PR and the issue you pointed out.

@yanns
Copy link
Contributor Author

yanns commented Sep 6, 2021

Sangria is now maintained by some people.
Thanks a lot to @nickhudkins @sh0hei @xsoufiane for your help.
If you want to join the efforts, please talk to us on https://gitter.im/sangria-graphql/sangria-dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests