This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Add Node 10 to CI #2349
Merged
Add Node 10 to CI #2349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nschonni
reviewed
Apr 25, 2018
| @@ -67,6 +67,9 @@ | |||
| - nodejs_version: 9 | |||
| GYP_MSVS_VERSION: 2015 | |||
| APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2015 | |||
| - nodejs_version: 10 | |||
| GYP_MSVS_VERSION: 2015 | |||
There was a problem hiding this comment.
Looks like they've bump'd it to 2017 now, but we can look at that separately
https://github.com/nodejs/node/blob/master/BUILDING.md#windows-1
|
It'll be interesting to see if people run into issues then.
…On Thu., 26 Apr. 2018, 5:02 am Nick Schonning, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In appveyor.yml
<#2349 (comment)>:
> @@ -67,6 +67,9 @@
- nodejs_version: 9
GYP_MSVS_VERSION: 2015
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2015
+ - nodejs_version: 10
+ GYP_MSVS_VERSION: 2015
Looks like they've bump'd it to 2017 now, but we can look at that
separately
https://github.com/nodejs/node/blob/master/BUILDING.md#windows-1
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#2349 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAjZWDkzp_lj64fMkxMo2GnL5e3tdeJ3ks5tsMhCgaJpZM4Ti090>
.
|
jiongle1
pushed a commit
to scantist-ossops-m2/node-sass
that referenced
this pull request
Apr 7, 2024
jiongle1
pushed a commit
to scantist-ossops-m2/node-sass
that referenced
this pull request
Apr 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉