Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Add Node 10 to CI #2349

Merged
merged 2 commits into from
Apr 25, 2018
Merged

Add Node 10 to CI #2349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
408903d
Add Node 10 to CI
xzyfer Apr 25, 2018
f50b974
Bump [email protected] for Node 10
xzyfer Apr 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@ jobs:
- stage: platform-test
node_js: "node"
os: osx
- stage: platform-test
node_js: "9"
os: linux
- stage: platform-test
node_js: "9"
os: osx
- stage: platform-test
node_js: "7"
os: linux
Expand Down Expand Up @@ -49,14 +55,24 @@ addons:
packages:
- gcc-4.7
- g++-4.7
- gcc-4.9
- g++-4.9

before_install:
- echo $TRAVIS_NODE_VERSION
- npm config set python `which python`
- if [ $TRAVIS_OS_NAME == "linux" ]; then
export CC="gcc-4.7";
export CXX="g++-4.7";
export LINK="gcc-4.7";
export LINKXX="g++-4.7";
if [[ $(node -v) =~ "10" ]]; then
export CC="gcc-4.9";
export CXX="g++-4.9";
export LINK="gcc-4.9";
export LINKXX="g++-4.9";
else
export CC="gcc-4.7";
export CXX="g++-4.7";
export LINK="gcc-4.7";
export LINKXX="g++-4.7";
fi
fi
- nvm --version
- node --version
Expand Down
6 changes: 6 additions & 0 deletions appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@
- nodejs_version: 9
GYP_MSVS_VERSION: 2015
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2015
- nodejs_version: 10
GYP_MSVS_VERSION: 2015
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like they've bump'd it to 2017 now, but we can look at that separately
https://github.com/nodejs/node/blob/master/BUILDING.md#windows-1

APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2015

install:
- ps: Install-Product node $env:nodejs_version $env:platform
Expand Down Expand Up @@ -148,6 +151,9 @@
- nodejs_version: 9
GYP_MSVS_VERSION: 2015
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2015
- nodejs_version: 10
GYP_MSVS_VERSION: 2015
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2015

install:
- ps: Install-Product node $env:nodejs_version $env:platform
Expand Down