store: Record stats even on ExpandPostings error (thanos-io#6679)

Signed-off-by: Saswata Mukherjee <[email protected]>
saswatamcode · Aug 31, 2023 · 6520af2 · 6520af2
1 parent 2bad830
commit 6520af2
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/pkg/store/bucket.go b/pkg/store/bucket.go
@@ -1364,15 +1364,18 @@ func (s *BucketStore) Series(req *storepb.SeriesRequest, seriesSrv storepb.Store
 					"block.resolution": blk.meta.Thanos.Downsample.Resolution,
 				})
 
-				if err := blockClient.ExpandPostings(sortedBlockMatchers, seriesLimiter); err != nil {
-					span.Finish()
-					return errors.Wrapf(err, "fetch series for block %s", blk.meta.ULID)
-				}
 				onClose := func() {
 					mtx.Lock()
 					stats = blockClient.MergeStats(stats)
 					mtx.Unlock()
 				}
+
+				if err := blockClient.ExpandPostings(sortedBlockMatchers, seriesLimiter); err != nil {
+					onClose()
+					span.Finish()
+					return errors.Wrapf(err, "fetch postings for block %s", blk.meta.ULID)
+				}
+
 				part := newLazyRespSet(
 					srv.Context(),
 					span,