Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected debug logs in 1.2.0 #1413

Closed
PhilipDukhov opened this issue Jun 29, 2022 · 2 comments · Fixed by #1414
Closed

Unexpected debug logs in 1.2.0 #1413

PhilipDukhov opened this issue Jun 29, 2022 · 2 comments · Fixed by #1414
Assignees
Labels
bug Something isn't working

Comments

@PhilipDukhov
Copy link
Contributor

Describe the bug

I'm using gradle plugin with the following setup:

plugins {
    id("org.cqfn.diktat.diktat-gradle-plugin").version("1.2.0")
}

diktat {
    inputs {
        it.include("src/**/*.kt")
    }
}

Note that downgrading to 1.1.0 solves the issue

Expected behavior

I expect to see only issues related strings in the output

Observed behavior

I also see dozens of lines like this ones - looks like the count depends on processing files count:

09:32:05.102 [main] DEBUG org.cqfn.diktat.ruleset.rules.DiktatRuleSetProvider - Will run diktat-ruleset with diktat-analysis.yml (it can be placed to the run directory or the default file from resources will be used)
09:32:05.102 [main] DEBUG org.cqfn.diktat.common.config.rules.RulesConfigReader - Using diktat-analysis.yml file from the following path: .../diktat-analysis.yml
09:32:05.384 [Thread-0] DEBUG org.cqfn.diktat.ruleset.rules.DiktatRuleSetProvider - Will run diktat-ruleset with diktat-analysis.yml (it can be placed to the run directory or the default file from resources will be used)
09:32:05.385 [Thread-0] DEBUG org.cqfn.diktat.common.config.rules.RulesConfigReader - Using diktat-analysis.yml file from the following path: .../diktat-analysis.yml

Steps to Reproduce

  1. Open attached sample project
  2. run ./gradlew diktatCheck

Environment information

  • diktat version: 1.2.0
  • build tool (maven/gradle): gradle
  • how is diktat run (CLI, plugin, etc.): plugin
  • kotlin version: 1.7.0
  • operating system: MacOS
@PhilipDukhov PhilipDukhov added the bug Something isn't working label Jun 29, 2022
@orchestr7
Copy link
Member

@PhilipDukhov thank you for this report! Looks like we made 1.2.0 release very dirty. Today or tomorrow we will releases 1.2.1 with several fixes, including this one

@petertrr
Copy link
Member

Yes, we'll fix it in 1.2.1 by adding configuration for logback, and we have #1394 for more thorough investigation of logging, the problem is described in that issue

petertrr added a commit that referenced this issue Jun 30, 2022
### What's done:
* Initialize loggers using kotlin-logging and extension from ktlint-core

This pull request closes #1413. Full description of the problem is in #1394
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants