-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ktlint's mechanism to initialize loggers #1414
Conversation
### What's done: * Added logback.xml to diktat-ruleset
Codecov Report
@@ Coverage Diff @@
## master #1414 +/- ##
============================================
- Coverage 83.39% 83.37% -0.02%
Complexity 2557 2557
============================================
Files 106 107 +1
Lines 7598 7599 +1
Branches 2095 2095
============================================
Hits 6336 6336
- Misses 373 374 +1
Partials 889 889
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
### What's done: * Add dependencies * Initialize loggers using kotlin-logging and extension from ktlint-core
This reverts commit e33bef9.
### What's done: * Added logback.xml to diktat-ruleset
this problem is relevant for gradle plugin (because we run ktlint as |
In maven plugin we don't depend on ktlint-cli and therefore don't depend on |
### What's done: * Added LoggingUtils.kt
There aren't logging in ktlint\diktat code which is called by maven plugin, are there? |
We are using a logger returned by |
What's done:
This pull request closes #1413. Full description of the problem is in #1394