Implementation of rule 3.5 - indentation #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Implemented rule * Added tests * Updated rules-config.json * Updated available-rules.md
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
============================================
+ Coverage 78.21% 78.48% +0.27%
- Complexity 407 435 +28
============================================
Files 23 27 +4
Lines 1207 1343 +136
Branches 389 428 +39
============================================
+ Hits 944 1054 +110
- Misses 114 119 +5
- Partials 149 170 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
### What's done: * Added indentation handler for KDoc * Refactoring
# Conflicts: # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/constants/Warnings.kt # diktat-rules/src/main/resources/rules-config.json # info/available-rules.md
### What's done: * Refactoring * Added checker for super type list * Added increase of indent after assignment operator * Added checker for dot calls * More tests
# Conflicts: # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/constants/Warnings.kt # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/DiktatRuleSetProvider.kt # diktat-rules/src/main/resources/rules-config.json # info/available-rules.md
### What's done: * Fixed code style
### What's done: * Refactoring * Comments and documentation
orchestr7
reviewed
Jul 27, 2020
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/DiktatRuleSetProvider.kt
Outdated
Show resolved
Hide resolved
### What's done: * Moved IndentationRule after all other rules
orchestr7
reviewed
Jul 27, 2020
| configuration = IndentationConfig(configRules.getRuleConfig(WRONG_INDENTATION)?.configuration | ||
| ?: mapOf()) | ||
| customIndentationCheckers = listOf( | ||
| AssignmentOperatorChecker(configuration), |
There was a problem hiding this comment.
do you check lambdas?
a newline after ->
There was a problem hiding this comment.
Not explicitly; every opening brace causes increase of indentation, and as a consequence body of lambda is indented.
petertrr
added a commit
that referenced
this pull request
Jul 31, 2020
* Implementation of rule 3.5 - indentation ### What's done: * Implemented rule * Added tests * Updated rules-config.json * Updated available-rules.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #62
What's done:
Fixmes:
KDOC_LEADING_ASTERISKs