Port pc find references from metals #20544
Conversation
project/Build.scala
Outdated
| @@ -1341,12 +1341,14 @@ object Build { | |||
| BuildInfoPlugin.buildInfoDefaultSettings | |||
|
|
|||
| def presentationCompilerSettings(implicit mode: Mode) = { | |||
| val mtagsVersion = "1.3.1" | |||
| val mtagsVersion = "1.3.1+63-1a8f4659-SNAPSHOT" | |||
There was a problem hiding this comment.
Should wait for a stable metals release.
There was a problem hiding this comment.
We can update to 1.3.2 now 🎉
kasiaMarek
force-pushed
the
pc-references
branch
from
a89f2cf to
3d58c2a
Compare
|
Looks like there is an issue with java compat in the compiler - symbol that seems to be supposed to point to |
| driver.run(uri, source) | ||
| given ctx: Context = driver.currentCtx | ||
|
|
||
| val unit = driver.currentCtx.run.units.head |
There was a problem hiding this comment.
quickfix:
| val unit = driver.currentCtx.run.units.head | |
| private val run = driver.currentCtx.run | |
| val unit = run.units.head |
(I was incorrect before about the java compat thing). This is ending up a bit hard to minimize since it both depends on the bootstrapped scala compiler and has to be compiled by it (nonbootstrapped works fine). My attempts to have it crash with scala3-bootstrapped/scalac -with-compiler are also proving unsuccessful. I might not be able to come up with the minimization after all, but the quick fix should help
kasiaMarek
force-pushed
the
pc-references
branch
from
3d58c2a to
fdd6a4a
Compare
Backports #20544 to the LTS branch. PR submitted by the release tooling. [skip ci]
scalameta/metals#5940
scalameta/metals#6429