improvement: don't run compileAndLookForNewReferences
#6429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasiaMarek
force-pushed
the
i6348
branch
2 times, most recently
from
886e95d to
52debb7
Compare
tgodzik
requested changes
May 28, 2024
| @@ -82,7 +87,8 @@ final class ReferenceProvider( | |||
| 0.01, | |||
| ) | |||
|
|
|||
| val entry = IdentifierIndex.IndexEntry(id, bloom) | |||
| val entry = | |||
| IdentifierIndex.IndexEntryWithStaleInfo(id, bloom, isStale = false) | |||
There was a problem hiding this comment.
Why not just IndexEntry? IndexEntryWithStaleInfo sounds like it actually always is stale.
There was a problem hiding this comment.
I just don't need that field in identifierIndex. The naming is quite unfortunate, so I'm open to suggestions. Should I just have this useless field be in identifierIndex too?
There was a problem hiding this comment.
MaybeStaleIndexEntry ? Not perfect either
mtags/src/main/scala-2/scala/meta/internal/mtags/MtagsEnrichments.scala
Outdated
Show resolved
Hide resolved
|
|
||
| try toSymbols(pkg, names) | ||
| val (toNames, rest) = |
There was a problem hiding this comment.
The logic here seems duplicated with WorkspaceSymbolSearch
kasiaMarek
force-pushed
the
i6348
branch
2 times, most recently
from
f0d5843 to
9ed940e
Compare
tgodzik
approved these changes
May 29, 2024
…okForNewReferences` use pc for stale semanticdbs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would run recompile for inverse build targets after
go to referencesto find if there are no new references. This would cause a lot of recompilations in presence of compilation errors. Since now we usepcas fallback for finding references we can use it always for files that have stale semanticdb.resolves: #6348
Since now a lot more tests use
pcfor references this showed a few issues with that. The fixes probably have to also be migrated to Scala 3 pc.