cluster_tools: In worker, use Python's defaults if logging_config is missing
#1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, Python's default log level is `logging.WARNING`, not `logging.DEBUG`. Before this change, some packages (e.g., `h5py`) would flood the log. Not only would this is large log files (hundreds of MBs), but it would also slow down execution.
hotzenklotz
approved these changes
Jan 16, 2025
| "logging_config", | ||
| {"level": logging.DEBUG, "format": "%(asctime)s %(levelname)s %(message)s"}, | ||
| ) | ||
| logging_config = meta_data.get("logging_config", dict()) |
There was a problem hiding this comment.
Nitpick: Using an empty dict will also reset our default logging format to Python's default ("%(levelname)s:%(name)s:%(message)s" Source Code). I think that is acceptable.
|
FYI, this change should be released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes
cluster_tools, such that Python's default values are used in the absence of a user-specifiedlogging_config. In particular, this commit "increases" the default logging level fromlogging.DEBUGto Python's default oflogging.WARNING. Without this change, some packages (e.g., H5py) are flooding the log. Not only does this result in large log files (tens of MBs per file for some of my jobs), but it also slows down execution.