Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster_tools: In worker, use Python's defaults if logging_config is missing #1235

Merged
merged 2 commits into from
Jan 16, 2025
Merged

cluster_tools: In worker, use Python's defaults if logging_config is missing #1235

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a859c0
If `logging_config` is missing, use Python's defaults
amotta Jan 14, 2025
e391212
Merge branch 'master' into python-default-logging
hotzenklotz Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions cluster_tools/cluster_tools/remote.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,10 +115,7 @@ def setup_logging(
)
meta_data["logging_setup_fn"](log_file_path)
else:
logging_config = meta_data.get(
"logging_config",
{"level": logging.DEBUG, "format": "%(asctime)s %(levelname)s %(message)s"},
)
logging_config = meta_data.get("logging_config", dict())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: Using an empty dict will also reset our default logging format to Python's default ("%(levelname)s:%(name)s:%(message)s" Source Code). I think that is acceptable.


logging.debug(
"Setting up logging.basicConfig (potentially overwriting logging configuration of the main script). Config: {}".format(
Expand Down
Loading