Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-publish diagnostics for warnings #712

Closed
wants to merge 4 commits into from
Closed

Re-publish diagnostics for warnings #712

wants to merge 4 commits into from

Conversation

jvican
Copy link
Contributor

@jvican jvican commented Nov 13, 2018

Introduces the ability to diff the changed source files from one analysis to the other one and then use this information to know which warnings in previous runs should still be logged because new compilations have not compiled their origin source files.

See #696

Test that we contain the scala-library jar and enable the sources
classifier in the test sources project.
@jvican jvican added feature build server Any issue or pull request that has to do with hot compilers or BSP. task / compile labels Nov 13, 2018
Fixes #696. We are still not
sending compile reports and diagnostics as we should for bspv2, so we'll
whenever we migrate to bsp v2 we'll need to adjust our handling.
@jvican
Copy link
Contributor Author

jvican commented Nov 19, 2018

Closing because #722 includes these changes.

@jvican jvican closed this Nov 19, 2018
@tgodzik tgodzik deleted the ticket/696 branch September 7, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build server Any issue or pull request that has to do with hot compilers or BSP. feature task / compile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant