Migrate to bsp v2 partially #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olafurpg
reviewed
Nov 16, 2018
frontend/src/main/scala/bloop/reporter/BspProjectReporter.scala
Outdated
Show resolved
Hide resolved
jvican
added
build server
jvican
force-pushed
the
topic/bsp-v2
branch
2 times, most recently
from
69494c1 to
cd384a0
Compare
|
Includes #712. |
Test that we contain the scala-library jar and enable the sources classifier in the test sources project.
Fixes #696. We are still not sending compile reports and diagnostics as we should for bspv2, so we'll whenever we migrate to bsp v2 we'll need to adjust our handling.
It's a partial migration because we have not yet adapted to bsp 2.0 for test, run and a few other endpoints. However, we implement the most urgent endpoints required for BSP clients to start their migration to 2.0. The way we test compilation in the tests has changed substantially. In this commit, we introduce a fine-grained way of testing diagnostics as well as other compilation invariants. In general, this commit adds: 1. A clearer separation of diagnostics reporting for CLI and for BSP. (Both have opposing interests when it comes to reporting diagnostics) 2. In-depth tests that check the correct behaviour of BSP reporting for clients, including reporting whenever errors are cleared or whenever there is a no-op incremental cycle. 3. A better way of getting previous compilation problems where we don't depend on the source infos of the Zinc analysis.
olafurpg
approved these changes
Nov 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We disable tests for
testandrunfor now, only focusing on the mostimportant BSP tasks to ease the migration in the BSP clients,
concretely diagnostics,
sourcesand compile. There is a lot ofinformation in the commit messages.