Use bidirectional streaming RPCs in DistributedTransactionService #228
Conversation
| return new GrpcTransaction( | ||
| response.getTransactionId(), stub, metadataManager, namespace, tableName); | ||
| }); | ||
| GrpcTransactionService service = new GrpcTransactionService(stub, metadataManager); |
There was a problem hiding this comment.
I'm wondering if it should create GrpcTransactionService object in every start.
If GrpcTransactionManager object singleton is shared (, which is most of the cases,) it seems not really effective?
Or, should GrpcTransactionManager be created for each transaction?
Ah, probably, it's created for managing finished and the latch separately?
There was a problem hiding this comment.
Thank you for reviewing this!
Ah, probably, it's created for managing finished and the latch separately?
Yes, GrpcTransactionService indicates things like a transaction session (assigned to a gRPC bidirectional stream), so we need to instantiate it per transaction. Maybe, the name (GrpcTransactionService) is not good. I will try to rename it to a better one. Thanks!
brfrn169
force-pushed
the
use-bidirectional-streaming-in-transaction
branch
from
fd7472e to
5839fae
Compare
| import javax.annotation.concurrent.NotThreadSafe; | ||
|
|
||
| @NotThreadSafe | ||
| public class GrpcTransactionBidirectionalStream implements StreamObserver<TransactionResponse> { |
There was a problem hiding this comment.
| public class GrpcTransactionBidirectionalStream implements StreamObserver<TransactionResponse> { | |
| public class GrpcTransactionOnBidirectionalStream implements StreamObserver<TransactionResponse> { |
maybe?
brfrn169
force-pushed
the
use-bidirectional-streaming-in-transaction
branch
from
5839fae to
2af57be
Compare
This PR changes
DistributedTransactionServiceto use bidirectional streaming RPCs in gRPC.After it's merged, I will work on changing
DistributedStorageServiceto use bidirectional streaming RPCs for scan operations, as well.Please take a look!