Use bidirectional streaming RPCs for scan operations in DistributedStorageService #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brfrn169
force-pushed
the
use-bidirectional-streaming-in-scanner-in-storage
branch
from
130ca57 to
a00e837
Compare
|
I rebased this to fix the conflicts. Please take a look! |
feeblefakie
approved these changes
Jul 6, 2021
| rpc ScanNext (ScanNextRequest) returns (ScanNextResponse) { | ||
| } | ||
| rpc CloseScanner (CloseScannerRequest) returns (google.protobuf.Empty) { | ||
| rpc Scan (stream ScanRequest) returns (stream ScanResponse) { |
| Scan scan = 1; | ||
| int32 fetch_count = 2; | ||
| optional int32 fetch_count = 2; |
There was a problem hiding this comment.
Oh, I didn't know optional is back now 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the scan operations for
DistributedStorageServiceto use bidirectional streaming RPCs in gRPC. I basically did the same things in #228.Please take a look!