Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename JdbcDatabaseAdmin to JdbcAdmin #456

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Rename JdbcDatabaseAdmin to JdbcAdmin #456

merged 1 commit into from
Jan 11, 2022

Conversation

brfrn169
Copy link
Collaborator

@brfrn169 brfrn169 commented Jan 9, 2022

This PR renames JdbcDatabaseAdmin to JdbcAdmin because I think JdbcAdmin is a more proper name. Please take a look!

@brfrn169 brfrn169 self-assigned this Jan 9, 2022
feeblefakie
feeblefakie approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

thongdk8
thongdk8 approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@thongdk8 thongdk8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@brfrn169 brfrn169 merged commit ca16873 into master Jan 11, 2022
@brfrn169 brfrn169 deleted the rename-JdbcDatabaseAdim branch January 11, 2022 03:15
brfrn169 added a commit that referenced this pull request Feb 14, 2022
@brfrn169
Rename JdbcDatabaseAdmin to JdbcAdmin (#456)
dfc8357
This was referenced Oct 5, 2023
Merged
Merged
Merged
This was referenced Oct 18, 2023
Merged
Merged
Merged
@Torch3333 Torch3333 mentioned this pull request Nov 1, 2023
Merged
6 tasks
@jnmt jnmt mentioned this pull request Nov 16, 2023
Merged
6 tasks
This was referenced Nov 20, 2023
Merged
Merged
Merged
@komamitsu komamitsu mentioned this pull request Feb 21, 2024
Closed
6 tasks
@komamitsu komamitsu mentioned this pull request Mar 22, 2024
Closed
6 tasks
@komamitsu komamitsu mentioned this pull request Apr 10, 2024
Merged
6 tasks
@jnmt jnmt mentioned this pull request Apr 18, 2024
Merged
6 tasks
@komamitsu komamitsu mentioned this pull request Apr 19, 2024
Merged
6 tasks
This was referenced May 8, 2024
Merged
Merged
@komamitsu komamitsu mentioned this pull request May 14, 2024
Merged
6 tasks
This was referenced Jun 24, 2024
Merged
Merged
@komamitsu komamitsu mentioned this pull request Jun 26, 2024
Merged
6 tasks
@Torch3333 Torch3333 mentioned this pull request Jun 27, 2024
Merged
6 tasks
@josh-wong josh-wong mentioned this pull request Jul 1, 2024
Merged
6 tasks
@komamitsu komamitsu mentioned this pull request Jul 5, 2024
Merged
6 tasks
@Torch3333 Torch3333 mentioned this pull request Jul 11, 2024
Merged
6 tasks
@Torch3333 Torch3333 mentioned this pull request Jul 29, 2024
Merged
This was referenced Aug 6, 2024
Closed
Merged
Merged
Merged
@jnmt jnmt mentioned this pull request Aug 13, 2024
Closed
6 tasks
@jnmt jnmt mentioned this pull request Sep 20, 2024
Merged
6 tasks
@Torch3333 Torch3333 mentioned this pull request Sep 24, 2024
Merged
6 tasks
This was referenced Oct 30, 2024
Merged
Merged
@Torch3333 Torch3333 mentioned this pull request Nov 6, 2024
Merged
6 tasks
@komamitsu komamitsu mentioned this pull request Nov 8, 2024
Merged
6 tasks
@jnmt jnmt mentioned this pull request Nov 25, 2024
Merged
6 tasks
@Torch3333 Torch3333 mentioned this pull request Dec 6, 2024
Merged
6 tasks
This was referenced Dec 19, 2024
Merged
Merged
Closed
This was referenced Jan 10, 2025
Merged
Merged
Merged
This was referenced Jan 23, 2025
Merged
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thongdk8 thongdk8 thongdk8 approved these changes

@feeblefakie feeblefakie feeblefakie approved these changes

Assignees

@brfrn169 brfrn169

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brfrn169 @feeblefakie @thongdk8