scx_rustland: interactive tuning #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 10, 2024 14:39
Some high-priority tasks may have a weight too high, that can potentially disrupt the slice boost optimization logic, causing interactive tasks to be less responsive. In line with rustland's focus on prioritizing interactive tasks, prevent giving too much CPU bandwidth to such high-priority tasks by limiting the maximum task weight to 1000. This allows to maintain a good level of system responsiveness even in presence of tasks with a really high priority. Signed-off-by: Andrea Righi <[email protected]>
In line with rustland's focus on prioritizing interactive tasks, set the default base time slice to 5ms. This allows to mitigate potential audio craking issues or system lags when the system is overloaded or under memory pressure condition (i.e., #96 (comment)). A downside of this change is to introduce potential regressions in the throughput of CPU-intensive workloads, but in such scenarios rustland may not be the optimal choice and alternative schedulers may be preferred. Signed-off-by: Andrea Righi <[email protected]>
htejun
approved these changes
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of adjustments that have been empirically proven to be highly effective in improving system responsiveness, particularly in the context of gaming and live conferencing / live streaming workloads.
Reducing the base time slice from 20ms to 5ms helps prevent potential audio cracking issues and sporadic lags under average load conditions. Additionally, setting a cap on the maximum task weight helps prevent similar issues when tasks with very high priority are running within the same SCHED_EXT scheduling class.