Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scx_rustland: interactive tuning #181

Merged
merged 2 commits into from
Mar 10, 2024
Merged

scx_rustland: interactive tuning #181

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a7161c
scx_rustland: limit range of task weight
Mar 9, 2024
155444e
scx_rustland: set default time slice to 5ms
Mar 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions scheds/rust/scx_rustland/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,8 @@ const SCHEDULER_NAME: &'static str = "RustLand";
///
#[derive(Debug, Parser)]
struct Opts {
/// Scheduling slice duration in microseconds.
#[clap(short = 's', long, default_value = "20000")]
/// Scheduling slice duration in microseconds (default is 5ms).
#[clap(short = 's', long, default_value = "5000")]
slice_us: u64,

/// Time slice boost: increasing this value enhances performance of interactive applications
Expand Down Expand Up @@ -391,10 +391,13 @@ impl<'a> Scheduler<'a> {
// NOTE: we should make this threshold a tunable, but for now let's assume that a moving
// average of 10 voluntary context switch per second is enough to classify the task as
// interactive.
//
// NOTE: some tasks may have a very high weight, that can potentially disrupt our slice
// boost optimizations, therefore always limit the task priority to a max of 1000.
let weight = if task_info.avg_nvcsw >= 10 {
task.weight * self.slice_boost.max(1)
task.weight.min(1000) * self.slice_boost.max(1)
} else {
task.weight
task.weight.min(1000)
};

// Scale the time slice by the task's priority (weight).
Expand Down