Merge pull request #1197 from mpoiriert/patch-1

Fix deprecated assertFileNotExist
schmittjoh · May 12, 2020 · 5eb72f4 · 5eb72f4
2 parents 8727285 + 34c3e78
commit 5eb72f4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/composer.json b/composer.json
@@ -42,7 +42,7 @@
         "symfony/form": "^3.0|^4.0|^5.0",
         "symfony/filesystem": "^3.0|^4.0|^5.0",
         "symfony/expression-language": "^3.0|^4.0|^5.0",
-        "phpunit/phpunit": "^7.5||^8.0||^9.0",
+        "phpunit/phpunit": "^8.0||^9.0",
         "doctrine/coding-standard": "^5.0"
     },
     "conflict": {

diff --git a/tests/SerializerBuilderTest.php b/tests/SerializerBuilderTest.php
@@ -14,6 +14,8 @@
 use JMS\Serializer\Tests\Fixtures\PersonSecretWithVariables;
 use JMS\Serializer\Type\ParserInterface;
 use JMS\Serializer\Visitor\Factory\JsonSerializationVisitorFactory;
+use PHPUnit\Framework\Constraint\FileExists;
+use PHPUnit\Framework\Constraint\LogicalNot;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\ExpressionLanguage\ExpressionFunction;
 use Symfony\Component\ExpressionLanguage\ExpressionLanguage;
@@ -41,7 +43,8 @@ public function testBuildWithoutAnythingElse()
 
     public function testWithCache()
     {
-        self::assertFileNotExists($this->tmpDir);
+        // @todo change to static::assertFileNotExists when support for PHPUnit 8 and PHP 7.2 is dropped
+        static::assertThat($this->tmpDir, new LogicalNot(new FileExists()));
 
         self::assertSame($this->builder, $this->builder->setCacheDir($this->tmpDir));
         $serializer = $this->builder->build();