Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated assertFileNotExist #1197

Merged
merged 1 commit into from
May 12, 2020
Merged

Conversation

mpoiriert
Copy link
Contributor

@mpoiriert mpoiriert commented May 11, 2020

Q A
Bug fix? yes
New feature? no
Doc updated no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #...
License MIT

@goetas
Copy link
Collaborator

goetas commented May 11, 2020

I think that you should increase the minimum required version of phpunit, as some builds are failing

@mpoiriert
Copy link
Contributor Author

Yes you are right. I have remove 7 since it reach it's end of support

@mpoiriert
Copy link
Contributor Author

mpoiriert commented May 11, 2020

So it's not compatible with PHPUnit 8.0 either.

Do you want me to remove it ? If there is no need to have a older version require dev.
9 Is only with php 7.3. So we will have a conflict.
I'll need to remove my fix but do you want me to still remove PHPUnit 7 or I just cancel the PR ?

@goetas
Copy link
Collaborator

goetas commented May 12, 2020

I think that removing phpunit 7 is ok, regarding your changes, unfortunately I think that we have to postpone them

Temporary fix of deprecated assertFileNotExist so we do not have warning
@mpoiriert
Copy link
Contributor Author

There is always a way.

I did that so we don't have the deprecated warning, it's a temporary fix.

@goetas goetas merged commit 5eb72f4 into schmittjoh:master May 12, 2020
@goetas
Copy link
Collaborator

goetas commented May 12, 2020

nice! thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants