Instructions for upgrading from addData in 1.x don't work

[GKFX]

Q	A
Bug report?	yes
Feature request?	no
BC Break report?	no
RFC?	no

The provided instructions for upgrading from addData in 1.x don't work. This is code from a project using the Symfony bundle. Instructions were (UPGRADING.md)

Removed deprecated method JsonSerializationVisitor::addData, use :visitProperty(new StaticPropertyMetadata('', 'name', 'value'), null) instead

Steps required to reproduce the problem

1. My old code (extract from https://github.com/camdram/camdram/blob/38216b3fe4c3b87d0f2f74d73a2521a315c0d920/src/Acts/CamdramApiBundle/Serializer/JsonEventSubscriber.php)

public function onPostSerialize(ObjectEvent $event)
{
    // ...
    $visitor->addData('_links', $linkJson); // $linkJson is an array
    $visitor->addData('_type', strtolower($class->getShortName()));
}

2. My new code, now with library version v2.0.2, following instructions provided in UPDATING.md:

$visitor->visitProperty(new StaticPropertyMetadata('', '_links', $linkJson), null);

3. My new code, having ignored the documentation and read the source instead ;)

$visitor->visitProperty(new StaticPropertyMetadata('', '_links', null), $linkJson);

Expected Result

    "_links": {
        "self": "\/shows\/2020-the-phantom-of-the-opera",
        "venue": "\/venues\/demo-venue",
        "society": "\/societies\/society-10"
    },
    "_type": "show"

formed part of the output with with 1.x and was expected with method 2.

Actual Result

The expected JSON did not appear with method 2. It did appear with method 3.

Is this a bug in the code or a bug in the documentation? I.e. should I continue using method 3 or wait until a fix is released that makes method 2 work?

[goetas]

hmm, that's interesting...

$visitor->visitProperty(new StaticPropertyMetadata('', '_links', $linkJson), null);

should be the right one... at least looking at

serializer/src/Accessor/DefaultAccessorStrategy.php

Line 54 in 4964dcb

if ($metadata instanceof StaticPropertyMetadata) {

[Sander-Toonen]

I have the same experience.
Are you sure the documentation is right?

[CHTJonas]

Bump!

[goetas]

Option 3 was the right way and #1066 updated the documentation

[CHTJonas]

That's grand - thanks!

[faysh]

What's the forth parameter ($groups) on StaticPropertyMetadata for? I added groups, but it doesn't exclude property at all. What I'm doing wrong?

[afkernohan]

It fails silently if your StaticPropertyMetadata is set up incorrectly:

    try {
        $v = $this->navigator->accept($v, $metadata->type);
    } catch (NotAcceptableException $e) {
        return;
    }