Explain once and for all the use of StaticPropertyMetadata #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value has to be specified twice. The first for the actual value, the second is for nullability checks and type auto detection.
This was referenced Aug 23, 2019
KDederichs
reviewed
Aug 23, 2019
| @@ -166,7 +166,7 @@ public function hasData(string $key): bool | |||
| } | |||
|
|
|||
| /** | |||
| * @deprecated Use visitProperty(new StaticPropertyMetadata(null, 'name', 'value'), null) instead | |||
| * @deprecated Use `::visitProperty(new StaticPropertyMetadata(null, 'name', 'value'), 'value')` instead | |||
There was a problem hiding this comment.
The first argument here is still null though which will cause the type checking in PHP 7 to fail again
There was a problem hiding this comment.
Good catch, fixed in 80aec06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to solve once and for all what has been attempted in #1117 #1107 and #1107
Also reported in #1116 #1030
The value has to be specified twice. The first for the actual value, the second is for nullability checks and type auto detection.