Change return type of SerializerBuilder::build() to Serializer #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the `SerializerBuilder` build will return an instance of `Serializer` which implements `SerializerInterface` and `ArrayTransformerInterface`. So the return type of `SerializerInterface` is wrong in this case.
icanhazstring
changed the title
goetas
reviewed
Jul 29, 2020
src/SerializerBuilder.php
Outdated
| @@ -499,7 +499,10 @@ public function setMetadataCache(CacheInterface $cache): self | |||
| return $this; | |||
| } | |||
|
|
|||
| public function build(): SerializerInterface | |||
| /** | |||
| * @return SerializerInterface&ArrayTransformerInterface | |||
There was a problem hiding this comment.
is this syntax supported? as I know php does not have yet intersection types
There was a problem hiding this comment.
|
the ci job https://travis-ci.org/github/schmittjoh/serializer/jobs/712201589 is failing |
|
Since the serializer builder is marked as final, we can just typehint the build method with |
|
@goetas we could do this as well. You are right :) |
|
thanks! |
icanhazstring
changed the title
|
Thanks |
|
Will this be tagged in a patch release soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
SerializerBuilderbuild will return an instance ofSerializerwhich implementsSerializerInterfaceandArrayTransformerInterface.So the return type of
SerializerInterfaceis wrong in this case.