Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intersection type annotations #2919

Closed
wants to merge 1 commit into from
Closed

Fix intersection type annotations #2919

wants to merge 1 commit into from

Conversation

geerteltink
Copy link

@geerteltink geerteltink commented Mar 29, 2020

This PR fixes intersection type annotations for Squiz.Commenting.FunctionComment.

Fixes #2887, #2806

@geerteltink
Copy link
Author

@VincentLanglet this is what you meant?

@digibeuk
Copy link

@geerteltink could you rebase your PR? I am also running into this issue where intersection types are not inspected correctly.

@geerteltink
Copy link
Author

If it gets merged than sure, if not than I don't see a point in keeping this PR up to date for so long.

@digibeuk
Copy link

If it gets merged than sure, if not than I don't see a point in keeping this PR up to date for so long.

Yes very true 😆 @VincentLanglet this PR was approved a long time ago but never merged, could you look into it again, it would be a big deal for us 👍🏻

@VincentLanglet
Copy link
Contributor

If it gets merged than sure, if not than I don't see a point in keeping this PR up to date for so long.

Yes very true 😆 @VincentLanglet this PR was approved a long time ago but never merged, could you look into it again, it would be a big deal for us 👍🏻

Im not maintainer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for Release
Development

Successfully merging this pull request may close these issues.

FunctionComment.SpacingAfterParamType not working with intersection types
3 participants