useful error when data is not an object #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
commented
Apr 21, 2021
dbu
commented
Apr 21, 2021
| @@ -234,6 +235,10 @@ public function accept($data, ?array $type = null) | |||
| throw new ExcludedClassException(); | |||
| } | |||
|
|
|||
| if (!is_object($data)) { | |||
| throw new InvalidArgumentException('Value at '.$this->context->getPath().' is expected to be an object of class '.$type['name'].' but is of type '.gettype($data)); | |||
There was a problem hiding this comment.
getPath only gives the model class but not the current property. do we know the name of the property we are currently looking at?
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was spending some time trying to figure out why i get:
Turns out i misconfigured a property that was supposed to be an array of objects as an object with the JMS annotations. From the error it is impossible to know what is wrong. With this exception, the path to the offending property is printed and we say what is actually expected.