Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useful error when data is not an object #1313

Merged
merged 4 commits into from
Apr 25, 2021
Merged

useful error when data is not an object #1313

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1f0334e
useful error when data is not an object
dbu Apr 21, 2021
34b94b6
typo
dbu Apr 21, 2021
4182205
cs
dbu Apr 21, 2021
6620223
Update SerializationGraphNavigator.php
dbu Apr 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/GraphNavigator/SerializationGraphNavigator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
use JMS\Serializer\Exception\CircularReferenceDetectedException;
use JMS\Serializer\Exception\ExcludedClassException;
use JMS\Serializer\Exception\ExpressionLanguageRequiredException;
use JMS\Serializer\Exception\InvalidArgumentException;
use JMS\Serializer\Exception\NotAcceptableException;
use JMS\Serializer\Exception\RuntimeException;
use JMS\Serializer\Exception\SkipHandlerException;
Expand Down Expand Up @@ -234,6 +235,10 @@ public function accept($data, ?array $type = null)
throw new ExcludedClassException();
}

if (!is_object($data)) {
throw new InvalidArgumentException('Value at '.$this->context->getPath().' is expected to be an object of class '.$type['name'].' but is of type '.gettype($data));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getPath only gives the model class but not the current property. do we know the name of the property we are currently looking at?

}
goetas marked this conversation as resolved.
Show resolved Hide resolved

$this->context->pushClassMetadata($metadata);

foreach ($metadata->preSerializeMethods as $method) {
Expand Down