-
Notifications
You must be signed in to change notification settings - Fork 224
fix: ensure that DoStatus is called for u2f devices #135
Conversation
I can confirm that this fixes my issue #121 too. |
Confirmed fix for me as well, though I'll have to open another ticket about the fact that it's not respecting that u2f is my default |
Thanks so much @austinylin! Hoping to get a chance to test this early next week. |
Well, I spent all morning trying to prove that this fix worked and it didn't. Then I realized I was on the wrong branch. Go me. |
@nickatsegment What does release timeline typically look like? |
@smiller171 It's pretty arbitrary, but I'm going to do one right now. |
Nice! |
v0.20.0 is hot off the presses. |
@nickatsegment Do you know how long it takes for a release to make its way into Homebrew? I don't know anything about how that works |
Generally we haven't touched it; we have our own internal homebrew for it. Looks like last time our friend @logikal contributed the PR: Homebrew/homebrew-core#36600 |
If no one beats me to it, I can do that tomorrow! |
I opened the PR: Homebrew/homebrew-core#38713 |
Thank you for taking care of that @vivianho! My apologies for not following through. |
Ran into #121 while trying to get setup with Duo + U2F. After comparing the flow in the code to the browser it looks like aws-okta isn't calling the Duo status endpoint properly. That is required to exchange the txid we get for something Okta will take.
I've tested this code with both U2F and Tokens and both now work.