Skip to content
This repository has been archived by the owner on May 18, 2021. It is now read-only.

fix: ensure that DoStatus is called for u2f devices #135

Merged
merged 1 commit into from
Apr 2, 2019

Conversation

austinylin
Copy link
Contributor

Ran into #121 while trying to get setup with Duo + U2F. After comparing the flow in the code to the browser it looks like aws-okta isn't calling the Duo status endpoint properly. That is required to exchange the txid we get for something Okta will take.

I've tested this code with both U2F and Tokens and both now work.

@austinylin austinylin changed the title Ensure that DoStatus is called for U2F devices fix: ensure that DoStatus is called for U2F devices Mar 28, 2019
@austinylin austinylin changed the title fix: ensure that DoStatus is called for U2F devices fix: ensure that DoStatus is called for u2f devices Mar 28, 2019
@vivianho
Copy link
Contributor

vivianho commented Mar 28, 2019

I can confirm that this fixes my issue #121 too.

@smiller171
Copy link
Contributor

Confirmed fix for me as well, though I'll have to open another ticket about the fact that it's not respecting that u2f is my default

@nickatsegment
Copy link
Contributor

Thanks so much @austinylin! Hoping to get a chance to test this early next week.

@nickatsegment
Copy link
Contributor

Well, I spent all morning trying to prove that this fix worked and it didn't. Then I realized I was on the wrong branch. Go me.

@nickatsegment nickatsegment merged commit 00408a7 into segmentio:master Apr 2, 2019
@smiller171
Copy link
Contributor

@nickatsegment What does release timeline typically look like?

@nickatsegment
Copy link
Contributor

@smiller171 It's pretty arbitrary, but I'm going to do one right now.

@smiller171
Copy link
Contributor

Nice!

@nickatsegment
Copy link
Contributor

v0.20.0 is hot off the presses.

@smiller171
Copy link
Contributor

@nickatsegment Do you know how long it takes for a release to make its way into Homebrew? I don't know anything about how that works

@nickatsegment
Copy link
Contributor

Generally we haven't touched it; we have our own internal homebrew for it. Looks like last time our friend @logikal contributed the PR: Homebrew/homebrew-core#36600

@logikal
Copy link
Contributor

logikal commented Apr 4, 2019

If no one beats me to it, I can do that tomorrow!

@vivianho
Copy link
Contributor

vivianho commented Apr 5, 2019

I opened the PR: Homebrew/homebrew-core#38713

@logikal
Copy link
Contributor

logikal commented Apr 9, 2019

Thank you for taking care of that @vivianho! My apologies for not following through.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants