feat: role flag for exec #202
Conversation
cmd/exec.go
Outdated
| @@ -44,6 +45,7 @@ func init() { | |||
| RootCmd.AddCommand(execCmd) | |||
| execCmd.Flags().DurationVarP(&sessionTTL, "session-ttl", "t", time.Hour, "Expiration time for okta role session") | |||
| execCmd.Flags().DurationVarP(&assumeRoleTTL, "assume-role-ttl", "a", time.Hour, "Expiration time for assumed role") | |||
| execCmd.Flags().StringVarP(&assumeRole, "assume-role", "r", "", "Assume a specified role using the role ARN") | |||
There was a problem hiding this comment.
I would make this assume-role-arn to be more explicit.
There was a problem hiding this comment.
made the change
There was a problem hiding this comment.
I was thinking the CLI flag should be --assume-role-arn for clarity.
There was a problem hiding this comment.
Sorry I misunderstood your comment. Will change to --assume-role-arn
This lets the user specify a role ARN with the `-r` flag to assume the specified role.
aadityasondhi
force-pushed
the
as/role-arn-flag
branch
from
42078b9 to
5ad3e02
Compare
| @@ -124,7 +126,9 @@ func execRun(cmd *cobra.Command, args []string) error { | |||
| return err | |||
| } | |||
|
|
|||
| if _, ok := profiles[profile]; !ok { | |||
| if _, ok := profiles[profile]; ok { | |||
| profiles[profile]["role_arn"] = assumeRoleARN | |||
There was a problem hiding this comment.
This feels kind of weird? You're modifying the in-memory config loaded from disk.
Also doesn't this break if -r is not set?
There was a problem hiding this comment.
I see. The testing we did was with #165 also enabled, so it did not break.
Could do non-empty check and skip if empty. Thoughts?
|
What's the use case here? Why not just write a new profile? |
|
The intended use case is when using aws-okta through automation scripts rather than a user. A lot easier to pass a role than creating a new profile. |
|
This PR has been replaced by #219 and can be closed. @nickatsegment I'll respond to your question on the usecase in the other PR. |
This lets the user specify a role ARN with the
-rflag to assume thespecified role.