Skip to content
This repository has been archived by the owner on May 18, 2021. It is now read-only.

feat: allow override of role arn to assume #219

Merged
merged 1 commit into from
Sep 24, 2019

Conversation

switj
Copy link
Contributor

@switj switj commented Sep 24, 2019

This lets the user specify a role ARN that will override what is present
in their profile. If no value is present in the profile it will be
added.

Co-authored-by: Aaditya Sondhi [email protected]

This lets the user specify a role ARN that will override what is present
in their profile. If no value is present in the profile it will be
added.

Co-authored-by: Aaditya Sondhi <[email protected]>
@switj
Copy link
Contributor Author

switj commented Sep 24, 2019

This PR is a followup to #202 I've taken over the work from Aaditya who has returned to school.

@switj switj mentioned this pull request Sep 24, 2019
@switj
Copy link
Contributor Author

switj commented Sep 24, 2019

What's the use case here? Why not just write a new profile?

The usecase is to use role ARN with a generic okta profile (that doesn't provide a role ARN). This reduces setup requirements and consistency issues between different profiles. This feature would be predominantly used in scripts.

Our main motivation is to remove the prerequisite when running a script to have a specific profile setup. The only profile required is the okta profile that users setup when they install aws-okta.

Does this seem like a reasonable usecase to motivate adding this feature?

@nickatsegment
Copy link
Contributor

nickatsegment commented Sep 24, 2019

Actually yes, that sounds pretty nice actually. We distribute a set of standard profiles here at Segment but can never really guarantee they're up to date. And our tooling often references them. So yeah, it might be nice to not have to assume it's up to date.

@nickatsegment nickatsegment merged commit e792b3f into segmentio:master Sep 24, 2019
@switj switj deleted the switj/role-arn branch September 24, 2019 18:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants