-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add WriterData field to the message struct #1059
add WriterData field to the message struct #1059
Conversation
Please take a look at this PR~ |
We're open to merging this, but we'd like to rename this new field to make it's purpose and limitations as clear as possible. Since Kafka has no built-in notion of "metadata" for messages like this, it only exists in the context of the Would you mind renaming |
thanks for your reply, I will update this PR quickly. |
@dominicbarnes please take a look, the field is renamed to |
@dominicbarnes please take a look at this PR. It looks the failed one is an unstable case, can you trigger it again? |
@dominicbarnes can you take a look at this issue ? any response is appreciated~ |
@achille-roussel @rhansen2 Can you help to take a look at this issue? We hope this can be merged |
I've triggered the failing kafka-011 run again, as I expect it to just be a flaky test as well. I'll review this PR once more with my team today, I expect it will be merged shortly. |
close #1054
This PR adds a new field
metadata interface{}
into themessage
struct, which can be used to hold any information, this can be helpful for the application to do post work after confirming the message is delivered.