Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php 8.4 compatibility for v3.74.x #957

Closed
wants to merge 1 commit into from
Closed

Conversation

Xon
Copy link

@Xon Xon commented Mar 22, 2024

#956 for the v3.74.x branch

@Xon Xon changed the title php 8.4 compatibility php 8.4 compatibility for v3.74.x Mar 22, 2024
@serbanghita
Copy link
Owner

@Xon the 3.74.x branch is for PHP 7.x only

@serbanghita
Copy link
Owner

@serbanghita
Copy link
Owner

path is better suited for 4.8.x

drbyte added a commit to drbyte/Mobile-Detect that referenced this pull request Aug 7, 2024
`MobileDetect::__construct(): Implicitly marking parameter $cache as nullable is deprecated, the explicit nullable type must be used instead`
`CacheException::__construct(): Implicitly marking parameter $previous as nullable is deprecated, the explicit nullable type must be used instead`

Updated Github Actions workflow to include PHP 8.4

Fixes serbanghita#956
Replaces serbanghita#957
drbyte added a commit to drbyte/Mobile-Detect that referenced this pull request Aug 7, 2024
`MobileDetect::__construct(): Implicitly marking parameter $cache as nullable is deprecated, the explicit nullable type must be used instead`
`CacheException::__construct(): Implicitly marking parameter $previous as nullable is deprecated, the explicit nullable type must be used instead`

Updated Github Actions workflow to include PHP 8.4

Fixes serbanghita#956
Replaces serbanghita#957
drbyte added a commit to drbyte/Mobile-Detect that referenced this pull request Aug 7, 2024
`MobileDetect::__construct(): Implicitly marking parameter $cache as nullable is deprecated, the explicit nullable type must be used instead`
`CacheException::__construct(): Implicitly marking parameter $previous as nullable is deprecated, the explicit nullable type must be used instead`

Updated Github Actions workflow to include PHP 8.4

Fixes serbanghita#956
Replaces serbanghita#957
drbyte added a commit to drbyte/Mobile-Detect that referenced this pull request Aug 7, 2024
`MobileDetect::__construct(): Implicitly marking parameter $cache as nullable is deprecated, the explicit nullable type must be used instead`
`CacheException::__construct(): Implicitly marking parameter $previous as nullable is deprecated, the explicit nullable type must be used instead`

Updated Github Actions workflow to include PHP 8.4

Fixes serbanghita#956
Replaces serbanghita#957
drbyte added a commit to drbyte/Mobile-Detect that referenced this pull request Aug 7, 2024
`MobileDetect::__construct(): Implicitly marking parameter $cache as nullable is deprecated, the explicit nullable type must be used instead`
`CacheException::__construct(): Implicitly marking parameter $previous as nullable is deprecated, the explicit nullable type must be used instead`

Updated Github Actions workflow to include PHP 8.4

Fixes serbanghita#956
Replaces serbanghita#957
@Xon Xon deleted the php84-compat branch December 5, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants