PHP 8.4 - implicit nulls are deprecated #960
Conversation
drbyte
force-pushed
the
fix-php-8.4-implicit-nulls
branch
3 times, most recently
from
976522f to
d0edfa3
Compare
`MobileDetect::__construct(): Implicitly marking parameter $cache as nullable is deprecated, the explicit nullable type must be used instead` `CacheException::__construct(): Implicitly marking parameter $previous as nullable is deprecated, the explicit nullable type must be used instead` Updated Github Actions workflow to include PHP 8.4 Fixes serbanghita#956 Replaces serbanghita#957
drbyte
force-pushed
the
fix-php-8.4-implicit-nulls
branch
from
d0edfa3 to
8033d6e
Compare
|
Note: phpstan hasn't yet fixed this same issue within their package. Fortunately it's backward compatible back to at least PHP 8.0, so all the tests are passing fine. |
|
Checking this asap, thank you! |
|
I see this has been merged, but not released. Is there any plans to release a new version including this any time soon? |
|
I hate to be that person, but PHP 8.4 is releasing tomorrow. Would be great to have this released. |
|
@serbanghita Can we get a release ASAP since PHP 8.4 has been released? |
|
This was merged and released. Please use https://github.com/serbanghita/Mobile-Detect/releases/tag/4.8.09 |
The `...-x-dev` version was only used temporarily during an older PR 960 to get tests to pass. This PR simply resets it to normal. Described at: serbanghita#960 (comment)
Use explicit nullable type.
MobileDetect::__construct(): Implicitly marking parameter $cache as nullable is deprecated, the explicit nullable type must be used insteadCacheException::__construct(): Implicitly marking parameter $previous as nullable is deprecated, the explicit nullable type must be used insteadAlso updated Github Actions workflow to include PHP 8.4
Fixes #956
Replaces #957