Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move FP8 to sglang #2366

Closed
wants to merge 8 commits into from
Closed

Move FP8 to sglang #2366

wants to merge 8 commits into from

Conversation

HaiShaw
Copy link
Collaborator

@HaiShaw HaiShaw commented Dec 5, 2024

Motivation

Move FP8 layers definition to SGLang

Modifications

As it is.
Kernels come next.

Checklist

  • [+] Format your code according to the Contributor Guide.
  • [+] Add unit tests as outlined in the Contributor Guide.
  • [+] Update documentation as needed, including docstrings or example tutorials.

zhyncs
zhyncs reviewed Dec 5, 2024
View reviewed changes
Copy link
Member

@zhyncs zhyncs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for vllm.model_executor.layers.quantization, LinearBase, and _custom_ops, everything else needs to be removed. Thanks!

python/sglang/srt/layers/quantization/fp8.py Outdated Show resolved Hide resolved
python/sglang/srt/layers/quantization/fp8.py
per_tensor_dequantize,
requantize_with_max_scale,
)
from vllm.model_executor.parameter import ModelWeightParameter, PerTensorScaleParameter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still in use, will decouple and migrate later.

python/sglang/srt/layers/quantization/fp8.py Outdated Show resolved Hide resolved
python/sglang/srt/layers/quantization/fp8.py Outdated Show resolved Hide resolved
python/sglang/srt/layers/quantization/fp8.py Outdated Show resolved Hide resolved
python/sglang/srt/layers/quantization/fp8.py Outdated Show resolved Hide resolved
@HaiShaw HaiShaw requested a review from zhyncs December 6, 2024 04:04
@HaiShaw HaiShaw closed this Dec 6, 2024
@zhyncs
Copy link
Member

zhyncs commented Dec 6, 2024

move to #2370
All credit goes to @HaiShaw Thanks!

@zhyncs zhyncs mentioned this pull request Dec 7, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merrymercy merrymercy Awaiting requested review from merrymercy merrymercy is a code owner

@Ying1123 Ying1123 Awaiting requested review from Ying1123 Ying1123 is a code owner

@ispobock ispobock Awaiting requested review from ispobock ispobock is a code owner

@zhyncs zhyncs Awaiting requested review from zhyncs zhyncs is a code owner

@ByronHsu ByronHsu Awaiting requested review from ByronHsu ByronHsu is a code owner

@hnyls2002 hnyls2002 Awaiting requested review from hnyls2002 hnyls2002 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@HaiShaw @zhyncs @xiaobochen123 @merrymercy @ByronHsu