Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move FP8 to SGLang #2370

Merged
merged 4 commits into from
Dec 6, 2024
Merged

Move FP8 to SGLang #2370

merged 4 commits into from
Dec 6, 2024

Conversation

zhyncs
Copy link
Member

@zhyncs zhyncs commented Dec 6, 2024

Motivation

cc @HaiShaw

Modifications

Checklist

  • Format your code according to the Contributor Guide.
  • Add unit tests as outlined in the Contributor Guide.
  • Update documentation as needed, including docstrings or example tutorials.

@zhyncs zhyncs changed the title New moe fp8 move MoE FP8 to SGLang Dec 6, 2024
@HaiShaw HaiShaw self-requested a review December 6, 2024 06:38
@HaiShaw HaiShaw changed the title move MoE FP8 to SGLang Move FP8 to SGLang Dec 6, 2024
@zhyncs zhyncs mentioned this pull request Dec 6, 2024
Closed
@zhyncs zhyncs merged commit 84d96b3 into main Dec 6, 2024
17 checks passed
@zhyncs zhyncs deleted the new_moe_fp8 branch December 6, 2024 07:42
@BBuf
Copy link
Collaborator

BBuf commented Dec 7, 2024

It caused circular import error in fused_moe_triton, please see #2386.

@zhyncs

@zhyncs
Copy link
Member Author

zhyncs commented Dec 7, 2024

I'll fix it soon cc @HaiShaw

@zhyncs zhyncs mentioned this pull request Dec 7, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaiShaw HaiShaw HaiShaw approved these changes

@merrymercy merrymercy Awaiting requested review from merrymercy merrymercy is a code owner

@Ying1123 Ying1123 Awaiting requested review from Ying1123 Ying1123 is a code owner

@ispobock ispobock Awaiting requested review from ispobock ispobock is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhyncs @BBuf @HaiShaw