Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with input detection due to overloaded ring buffer and fix buffer size being incorrect #2346

Merged

Conversation

kalaposfos13
Copy link
Contributor

Adds an axis noise filter and only updates outputs if a change happened to that output, meaning that there are now both less axis movement event spam, and now every input event only updates one output, instead of updating all of them with all but the updated one holding duplicate data from the previous entry, which was making the ring buffer holding input events being overloaded in two different ways. These features were once in my main remap PR, but I had to revert them, although it looks like whatever was the issue that led to that no longer applies, as from my testing, I couldn't find any significant regressions, but just to be safe, I'll open this as a draft and wait until it's tested on more games.

@sam20112011
Copy link

This PR fix this issue for me: #2340

@Hermiten
Copy link
Collaborator

Hermiten commented Feb 4, 2025

@ElBread3
Copy link
Contributor

ElBread3 commented Feb 4, 2025

Tested Minecraft, this PR appears to have gotten rid of menu input lag, but not any game input lag.

@kalaposfos13
Copy link
Contributor Author

I think I found a possible fix for Minecraft's (and maybe for other games') input lag, which is reducing the buffer size to 32, which is the number that's seen in Ghidra. It can be tested here: https://github.com/kalaposfos13/shadPS4/tree/mc-input-lag-hack

@kalaposfos13 kalaposfos13 force-pushed the remap-fix-input-overload branch from a53b4ed to 1d299e3 Compare February 4, 2025 21:10
@kalaposfos13 kalaposfos13 changed the title Fix issues with input detection due to overloaded ring buffer Fix issues with input detection due to overloaded ring buffer and fix buffer size being incorrect Feb 4, 2025
@kalaposfos13
Copy link
Contributor Author

Since this is a draft, and the ring buffer size change is at least partially related to this PR anyway, I figured I might as well add the Minecraft fix to here.

@Hermiten
Copy link
Collaborator

Hermiten commented Feb 5, 2025

I think you can and if there is a big problem, you will split it
Now we need some tests on games with and without this problem to be sure everything is good

@kalaposfos13 kalaposfos13 marked this pull request as ready for review February 5, 2025 16:43
@georgemoralis georgemoralis merged commit f111395 into shadps4-emu:main Feb 5, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants