Skip to content

Commit

Permalink
Continue supporting windows 7 with builds
Browse files Browse the repository at this point in the history
By using an older version of rust to build the artifacts on windows.

Alternatively we could build separate artifacts for windows 7, and
continue using the latest version of rust for later versions of windows
that are more optimized for more recent versions.

Fixes: #1550
  • Loading branch information
tmccombs committed Jun 14, 2024
1 parent f477c4f commit 7042dff
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/CICD.yml
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,9 @@ jobs:
uses: dtolnay/rust-toolchain@stable
with:
targets: ${{ matrix.job.target }}
# On windows, for now build with 1.77.2, so that it works on windows 7.
# When we update the MSRV again, we'll need to revisit this, and probably drop support for Win7
toolchain: "${{ contains(matrix.job.target, 'windows-') && '1.77.2' || 'stable' }}"

- name: Install cross
if: matrix.job.use-cross
Expand Down

4 comments on commit 7042dff

@abubelinha
Copy link

@abubelinha abubelinha commented on 7042dff Jul 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmccombs does this mean Windows 7 is still supported?

I am getting a 0xc0000005 error when I try to run fd on Windows 7 Home Premium SP1 64bit
(first time I try fd software)

This is the version I downloaded:
https://github.com/sharkdp/fd/releases/download/v10.1.0/fd-v10.1.0-i686-pc-windows-msvc.zip

Thanks
@abubelinha

@tmccombs
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some definition of supported.

I do not have access to a window 7 machine, so have no way to test that it actually works.

I also don't think we've had a release since I made that change to the deployment, so 10.1 wasn't built with support for windows 7.

You could try compiling it yourself. Or use a pre-10.0 version.

@abubelinha
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I downloaded this version and it seems to work OK:
https://github.com/sharkdp/fd/releases/download/v9.0.0/fd-v9.0.0-x86_64-pc-windows-msvc.zip

Thanks a lot.

@abubelinha
Copy link

@abubelinha abubelinha commented on 7042dff Aug 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reading your comments, I understand future releases might still be again compatible with Windows 7 systems. Correct?
(before dropping support to Windows 7 it would be nice if compiled binaries are provided to the highest possible version)

Please sign in to comment.