-
-
Notifications
You must be signed in to change notification settings - Fork 818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FD version 10 stopped working on Windows 7 #1550
Comments
This seems more like a complaint directed at the Rust project itself than an fd issue. If there's a way for us to build Windows 7 compatible binaries I think we'd be happy to add a separate build for that. |
It seems like there is a separate target for win7 (that is tier 3). I don't have any objection to adding a build for that |
well, that makes supporting this more difficult. |
Same here with fd-v10.1.0-i686-pc-windows-msvc.zip and fd-v10.1.0-x86_64-pc-windows-msvc.zip. |
Ok, I've compile fd v10.1.0 with the latest version that supports Win 7, Rust v1.75, and it output "error: package |
I don't like the idea of locking fd into supporting 1.75 forever to support an OS that is no longer officially supported by its vendor. Also, the main reason for upgrading to 1.77.2 in the first place is because of a CVE that impacts windows . See https://blog.rust-lang.org/2024/04/09/Rust-1.77.2.html. I don't feel comfortable including a build on the release page that has this known vulnerability. |
a) @ozwaldorf, the author of Lutgen app written in Rust, says that he was able to compile Windows 7 compatible (legacy) binary using Rustc 1.77.2. I verified that it worked as expected. b) @tmccombs Rust is no longer a language in which you can create apps that make life easier for as many people as possible. That's what we need to worry about, not what vendors like Microsoft do, because they are driven by the pursuit of profit, not a vision of a better world. Do you code to get that shiny "Silicon Valley approved" badge or to help neighbors? It reminds me of the famous Charlie Chaplin's speech (1940): “…We have developed speed but we have shut ourselves in: machinery that gives abundance has left us in want. Our knowledge has made us cynical, our cleverness hard and unkind. We think too much and feel too little: more than machinery we need humanity…”. |
Sure it's possible to compile for win7 with rust 1.77.2. But it sounds like it is a little more involved. And I don't have windows 7, or any version of windows for that matter, nor do I have access to CI for windows 7 to test that such a binary works. If someone were to make a reasonable pull request to add building a win7 binary to the github actions, I would probably merge it, with a disclaimer that said binary is untested (as, like the rust project, fd doesn't have windows 7 ci servers to test it on). I understand your frustration, but I don't currently have a good solution for providing a windows 7 compatible binary on the releases page. You do have some options though:
|
That's how @ozwaldorf set compilation chain via Github. |
Ah! Support wasn't removed until 1.78. Yeah I can add a windows build with 1.77 for now |
By using an older version of rust to build the artifacts on windows. Alternatively we could build separate artifacts for windows 7, and continue using the latest version of rust for later versions of windows that are more optimized for more recent versions. Fixes: sharkdp#1550
By using an older version of rust to build the artifacts on windows. Alternatively we could build separate artifacts for windows 7, and continue using the latest version of rust for later versions of windows that are more optimized for more recent versions. Fixes: sharkdp#1550
Checks
Describe the bug you encountered:
Rust language developers betrayed Windows 7 users by removing the feature to build binaries for this OS. They believe that since Microsoft has stopped supporting this OS (not because new versions bring something revolutionary, but to make money on sales), then they should follow. However, the support is not a determining factor for all users — this OS is sufficiently polished to perform its functions and remains in demand outside relatively well-off places. For example, C language developers understand this and their compilers do not require a new OS. The good hammer continues to hammer regardless of whether the warranty has expired.
This puts the authors of FD, a program written in Rust, in a difficult position because they need to either spit in the face of all those users outside the so-called golden billion who relied on FD all these years, or find a way to compile it (Tier3? Rust9x?).
Describe what you expected to happen:
No response
What version of
fd
are you using?10
Which operating system / distribution are you on?
The text was updated successfully, but these errors were encountered: