Add conditions pkg to support Build CRDs to operate on Conditions #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qu1queee
requested review from
HeavyWombat and
adambkaplan
and removed request for
xiujuan95 and
zhangtbj
qu1queee
force-pushed
the
qu1queee/conditions_br
branch
2 times, most recently
from
5351e3d to
556e8c0
Compare
qu1queee
force-pushed
the
qu1queee/conditions_br
branch
from
556e8c0 to
3b999a5
Compare
|
/retest |
|
Note that Conditions has official API support from Kubernetes in v1.19. In addition to an API defined in https://github.com/kubernetes/apimachinery/blob/master/pkg/apis/meta/v1/types.go#L1354-L1368 |
qu1queee
force-pushed
the
qu1queee/conditions_br
branch
from
3b999a5 to
edde66c
Compare
|
@adambkaplan cool, more than happy to rely on that in the future. We will just need to keep our local |
zhangtbj
reviewed
Nov 11, 2020
qu1queee
force-pushed
the
qu1queee/conditions_br
branch
2 times, most recently
from
25a38b9 to
07cfd48
Compare
openshift-ci-robot
added
lgtm
HeavyWombat
requested changes
Nov 17, 2020
qu1queee
force-pushed
the
qu1queee/conditions_br
branch
from
92a349f to
a043915
Compare
|
@HeavyWombat thanks, I added your suggestions. |
qu1queee
force-pushed
the
qu1queee/conditions_br
branch
from
a043915 to
adec8bf
Compare
zhangtbj
approved these changes
Nov 18, 2020
- Adding a generic conditions pkg, so that any controller that needs to support Conditions can use the pkg to set/retrieve their related conditions. - Adding a Condition of the type Succeeded for resources that run to completion, like the BuildRun - Adding a generic Condition types. This can be extended in the future with new fields. - Adding unit tests for the new conditions pkg. - Adding support for the Conditions pkg in the BuildRun, although the CRD is not yet generating or updating the Status.Condition object. This is done by extending the Status struct to include a Conditions field. The conditions framework is heavily based on https://github.com/knative/pkg/blob/master/apis/condition_set.go
This adds support for the CRD to inline with the BuildRun types changes.
qu1queee
force-pushed
the
qu1queee/conditions_br
branch
from
adec8bf to
cfd5d7e
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not yet fixing #307 , but rather the base framework so that we can operate on Conditions. We would need a new PR for how do we populate the Conditions field in the BuildRun.
This includes
Adding a generic conditions pkg, so that any controller that needs to support Conditions can use the pkg to set/retrieve their related conditions.
Adding a Condition of the type Succeeded for resources that run to completion, like the BuildRun
Adding a generic Condition types. This can be extended in the future with new fields.
Adding unit tests for the new conditions pkg.
Adding support for the Conditions pkg in the BuildRun, although the CRD is not yet generating or updating the Status.Condition object. This is done by extending the Status struct to include a Conditions field.
Extend BuildRun CRD with Conditions fields . This adds support for the CRD to inline with the BuildRun types changes.
Part of this conditions framework is heavily based on https://github.com/knative/pkg/blob/master/apis/condition_set.go