bn /eth/v1/beacon/blocks/{block_id} return wrong information on skipped block #2186
Assignees
Comments
|
As an update to those watching, it's not immediately clear what the return result should be: ethereum/beacon-APIs#126 However, I think it's reasonable for us to start returning 404 on skipped blocks. That seems to be what other clients have assumed. |
bors bot
pushed a commit
that referenced
this issue
Apr 24, 2021
…2272) ## Issue Addressed Resolves #2186 ## Proposed Changes 404 for any block-related information on a slot that was skipped or orphaned Affected endpoints: - `/eth/v1/beacon/blocks/{block_id}` - `/eth/v1/beacon/blocks/{block_id}/root` - `/eth/v1/beacon/blocks/{block_id}/attestations` - `/eth/v1/beacon/headers/{block_id}` ## Additional Info Co-authored-by: realbigsean <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Making get request on skipped block return earliest not skipped block
Version
docker sigp/lighthouse:v1.1.0
Present Behaviour
GET /eth/v1/beacon/blocks/554465
https://pyrmont.beaconcha.in/block/554465
return information of block 554464
https://pyrmont.beaconcha.in/block/554464
Expected Behaviour
GET /eth/v1/beacon/blocks/{block_id} (on skipped block)
should return 404
The text was updated successfully, but these errors were encountered: