Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - 404's on API requests for slots that have been skipped or orphaned #2272

Closed
wants to merge 4 commits into from

Conversation

realbigsean
Copy link
Member

Issue Addressed

Resolves #2186

Proposed Changes

404 for any block-related information on a slot that was skipped or orphaned

Affected endpoints:

  • /eth/v1/beacon/blocks/{block_id}
  • /eth/v1/beacon/blocks/{block_id}/root
  • /eth/v1/beacon/blocks/{block_id}/attestations
  • /eth/v1/beacon/headers/{block_id}

Additional Info

@realbigsean realbigsean added the ready-for-review The code is ready for review label Mar 29, 2021
@paulhauner
Copy link
Member

I'm thinking we don't include this PR in this weeks release, since it'll require a minor version bump and this release contains a bug fix that we want users on ASAP (#2283)

Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I think a regression test could potentially save our ass down the line.

@paulhauner paulhauner added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Apr 16, 2021
@michaelsproul michaelsproul added the backwards-incompat Backwards-incompatible API change label Apr 16, 2021
@michaelsproul
Copy link
Member

Tagging this as backwards-incompat, a new label I made to help us track breaking changes between releases

@realbigsean
Copy link
Member Author

Looks good to me, but I think a regression test could potentially save our ass down the line.

Updated!

@realbigsean realbigsean added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Apr 23, 2021
Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

bors r+

@paulhauner paulhauner added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Apr 24, 2021
bors bot pushed a commit that referenced this pull request Apr 24, 2021
…2272)

## Issue Addressed

Resolves #2186

## Proposed Changes

404 for any block-related information on a slot that was skipped or orphaned

Affected endpoints:
- `/eth/v1/beacon/blocks/{block_id}`
- `/eth/v1/beacon/blocks/{block_id}/root`
- `/eth/v1/beacon/blocks/{block_id}/attestations`
- `/eth/v1/beacon/headers/{block_id}`

## Additional Info



Co-authored-by: realbigsean <[email protected]>
@bors
Copy link

bors bot commented Apr 24, 2021

Build failed:

@paulhauner
Copy link
Member

bors retry+

bors bot pushed a commit that referenced this pull request Apr 25, 2021
…2272)

## Issue Addressed

Resolves #2186

## Proposed Changes

404 for any block-related information on a slot that was skipped or orphaned

Affected endpoints:
- `/eth/v1/beacon/blocks/{block_id}`
- `/eth/v1/beacon/blocks/{block_id}/root`
- `/eth/v1/beacon/blocks/{block_id}/attestations`
- `/eth/v1/beacon/headers/{block_id}`

## Additional Info



Co-authored-by: realbigsean <[email protected]>
@bors bors bot changed the title 404's on API requests for slots that have been skipped or orphaned [Merged by Bors] - 404's on API requests for slots that have been skipped or orphaned Apr 25, 2021
@bors bors bot closed this Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards-incompat Backwards-incompatible API change ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants