-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - 404's on API requests for slots that have been skipped or orphaned #2272
Conversation
I'm thinking we don't include this PR in this weeks release, since it'll require a minor version bump and this release contains a bug fix that we want users on ASAP (#2283) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I think a regression test could potentially save our ass down the line.
Tagging this as |
Updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one!
bors r+
…2272) ## Issue Addressed Resolves #2186 ## Proposed Changes 404 for any block-related information on a slot that was skipped or orphaned Affected endpoints: - `/eth/v1/beacon/blocks/{block_id}` - `/eth/v1/beacon/blocks/{block_id}/root` - `/eth/v1/beacon/blocks/{block_id}/attestations` - `/eth/v1/beacon/headers/{block_id}` ## Additional Info Co-authored-by: realbigsean <[email protected]>
Build failed: |
bors retry+ |
…2272) ## Issue Addressed Resolves #2186 ## Proposed Changes 404 for any block-related information on a slot that was skipped or orphaned Affected endpoints: - `/eth/v1/beacon/blocks/{block_id}` - `/eth/v1/beacon/blocks/{block_id}/root` - `/eth/v1/beacon/blocks/{block_id}/attestations` - `/eth/v1/beacon/headers/{block_id}` ## Additional Info Co-authored-by: realbigsean <[email protected]>
Pull request successfully merged into unstable. Build succeeded: |
Issue Addressed
Resolves #2186
Proposed Changes
404 for any block-related information on a slot that was skipped or orphaned
Affected endpoints:
/eth/v1/beacon/blocks/{block_id}
/eth/v1/beacon/blocks/{block_id}/root
/eth/v1/beacon/blocks/{block_id}/attestations
/eth/v1/beacon/headers/{block_id}
Additional Info