Implement feerecipient API for keymanager (VC)
#3173
Assignees
Labels
bellatrix
Required to support the Bellatrix Upgrade
Comments
This was referenced May 20, 2022
bors bot
pushed a commit
that referenced
this issue
Jul 6, 2022
## Issue Addressed * #3173 ## Proposed Changes Moved all `fee_recipient_file` related logic inside the `ValidatorStore` as it makes more sense to have this all together there. I tested this with the validators I have on `mainnet-shadow-fork-5` and everything appeared to work well. Only technicality is that I can't get the method to return `401` when the authorization header is not specified (it returns `400` instead). Fixing this is probably quite difficult given that none of `warp`'s rejections have code `401`.. I don't really think this matters too much though as long as it fails.
bors bot
pushed a commit
that referenced
this issue
Jul 6, 2022
## Issue Addressed * #3173 ## Proposed Changes Moved all `fee_recipient_file` related logic inside the `ValidatorStore` as it makes more sense to have this all together there. I tested this with the validators I have on `mainnet-shadow-fork-5` and everything appeared to work well. Only technicality is that I can't get the method to return `401` when the authorization header is not specified (it returns `400` instead). Fixing this is probably quite difficult given that none of `warp`'s rejections have code `401`.. I don't really think this matters too much though as long as it fails.
bors bot
pushed a commit
that referenced
this issue
Jul 6, 2022
## Issue Addressed * #3173 ## Proposed Changes Moved all `fee_recipient_file` related logic inside the `ValidatorStore` as it makes more sense to have this all together there. I tested this with the validators I have on `mainnet-shadow-fork-5` and everything appeared to work well. Only technicality is that I can't get the method to return `401` when the authorization header is not specified (it returns `400` instead). Fixing this is probably quite difficult given that none of `warp`'s rejections have code `401`.. I don't really think this matters too much though as long as it fails.
bors bot
pushed a commit
that referenced
this issue
Jul 6, 2022
## Issue Addressed * #3173 ## Proposed Changes Moved all `fee_recipient_file` related logic inside the `ValidatorStore` as it makes more sense to have this all together there. I tested this with the validators I have on `mainnet-shadow-fork-5` and everything appeared to work well. Only technicality is that I can't get the method to return `401` when the authorization header is not specified (it returns `400` instead). Fixing this is probably quite difficult given that none of `warp`'s rejections have code `401`.. I don't really think this matters too much though as long as it fails.
|
Resolved via #3213 🎉 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
An endpoint has been added to the keymanager API (our VC implements this) to support dynamically changing the suggested fee recipient:
ethereum/keymanager-APIs#24
I've had a few questions about this from large pools, it seems like desirable functionality. It should be fairly straight-forward to implement. We'll want to make sure we update our suggested fee recipient docs to include this method and describe how it interacts with the other methods we have.
The text was updated successfully, but these errors were encountered: