Implement feerecipient API for keymanager
#3198
Conversation
| }); | ||
| }) | ||
| } | ||
|
|
There was a problem hiding this comment.
I had to break up collect_preparation_data() into different functions
The logic for retrieving the fee recipient for a given public key was pulled out into get_preparation_data() for use in the API call. Because this function is called in a loop inside collect_preparation_data(), I made it accept a FeeRecipientFile object instead of reading from disk so that doesn't need to happen for each iteration of the loop. This required me to create read_fee_recipient_file().
Also @michaelsproul I had to resolve a merge conflict when I rebased this with your changes to collect_preparation_data().. I beleive I did it correctly but may want to look closely at this part.
ethDreamer
changed the title
feerecipient API for keymanager
|
Would you mind throwing a |
|
i'm going to re-open this from another branch that's been refactored |
Issue Addressed
feerecipientAPI for keymanager (VC) #3173