Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set user agent for builder calls #4185

Closed
michaelsproul opened this issue Apr 13, 2023 · 2 comments
Closed

Set user agent for builder calls #4185

michaelsproul opened this issue Apr 13, 2023 · 2 comments
Assignees
@michaelsproul
Labels
builder API enhancement New feature or request

Comments

@michaelsproul
Copy link
Member

michaelsproul commented Apr 13, 2023 •
edited
Loading

Description

The MEV relays analyse calls based on their HTTP user agent, which Lighthouse currently does not set. In the incident immediately after Capella, relays used the user-agent to block faulty Prysm nodes from requesting blocks and triggering failures.

Expected Behaviour

  • Add a default user agent header like Lighthouse/vX.Y.Z to each builder request.
  • (Optional) Add a CLI flag to configure this user agent

Note that when connecting to relays via mev-boost it will add its own version as a prefix of the CL supplied user agent, so we will often end up with a user agent like mev-boost/v1.5.0 Lighthouse/v4.1.0.
@michaelsproul michaelsproul added enhancement New feature or request builder API labels Apr 13, 2023
@michaelsproul michaelsproul self-assigned this Apr 17, 2023
@michaelsproul
Copy link
Member Author

I'll take this

@michaelsproul michaelsproul mentioned this issue Apr 17, 2023
Closed
bors bot pushed a commit that referenced this issue Apr 18, 2023
@michaelsproul
Set user agent on requests to builder (#4199)
e9a7316 
## Issue Addressed

Closes #4185

## Proposed Changes

- Set user agent to `Lighthouse/vX.Y.Z-<commit hash>` by default
- Allow tweaking user agent via `--builder-user-agent "agent"`
@michaelsproul
Copy link
Member Author

Closed by #4199

xenowits pushed a commit to xenowits/lighthouse that referenced this issue May 16, 2023
@michaelsproul @xenowits
Set user agent on requests to builder (sigp#4199)
8b18b30 
## Issue Addressed

Closes sigp#4185

## Proposed Changes

- Set user agent to `Lighthouse/vX.Y.Z-<commit hash>` by default
- Allow tweaking user agent via `--builder-user-agent "agent"`
ghost pushed a commit to oone-world/lighthouse that referenced this issue Jul 13, 2023
@michaelsproul
Set user agent on requests to builder (sigp#4199)
6846698 
## Issue Addressed

Closes sigp#4185

## Proposed Changes

- Set user agent to `Lighthouse/vX.Y.Z-<commit hash>` by default
- Allow tweaking user agent via `--builder-user-agent "agent"`
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this issue Jan 6, 2024
@michaelsproul @Woodpile37
Set user agent on requests to builder (sigp#4199)
fd18a72 
## Issue Addressed

Closes sigp#4185

## Proposed Changes

- Set user agent to `Lighthouse/vX.Y.Z-<commit hash>` by default
- Allow tweaking user agent via `--builder-user-agent "agent"`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelsproul michaelsproul

Labels
builder API enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michaelsproul