Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Set user agent on requests to builder #4199

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Set user agent on requests to builder #4199

wants to merge 2 commits into from

Conversation

michaelsproul
Copy link
Member

Issue Addressed

Closes #4185

Proposed Changes

  • Set user agent to Lighthouse/vX.Y.Z-<commit hash> by default
  • Allow tweaking user agent via --builder-user-agent "agent"

@michaelsproul michaelsproul added enhancement New feature or request ready-for-review The code is ready for review low-hanging-fruit Easy to resolve, get it before someone else does! builder API labels Apr 17, 2023
@michaelsproul michaelsproul added the v4.1.0 Post-Capella minor release label Apr 18, 2023
paulhauner
paulhauner approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I made a suggestion, it's not important though. Happy to merge as-is.

beacon_node/execution_layer/src/lib.rs Outdated Show resolved Hide resolved
@michaelsproul
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Apr 18, 2023
@michaelsproul
Set user agent on requests to builder (#4199)
e9a7316 
## Issue Addressed

Closes #4185

## Proposed Changes

- Set user agent to `Lighthouse/vX.Y.Z-<commit hash>` by default
- Allow tweaking user agent via `--builder-user-agent "agent"`
@paulhauner paulhauner mentioned this pull request Apr 18, 2023
Closed
@bors
Copy link

bors bot commented Apr 18, 2023

Pull request successfully merged into unstable.

Build succeeded:

@bors bors bot changed the title Set user agent on requests to builder [Merged by Bors] - Set user agent on requests to builder Apr 18, 2023
@bors bors bot closed this Apr 18, 2023
@michaelsproul michaelsproul deleted the builder-agent branch April 18, 2023 05:25
@michaelsproul michaelsproul mentioned this pull request Apr 20, 2023
Closed
xenowits pushed a commit to xenowits/lighthouse that referenced this pull request May 16, 2023
@michaelsproul @xenowits
Set user agent on requests to builder (sigp#4199)
8b18b30 
## Issue Addressed

Closes sigp#4185

## Proposed Changes

- Set user agent to `Lighthouse/vX.Y.Z-<commit hash>` by default
- Allow tweaking user agent via `--builder-user-agent "agent"`
ghost pushed a commit to oone-world/lighthouse that referenced this pull request Jul 13, 2023
@michaelsproul
Set user agent on requests to builder (sigp#4199)
6846698 
## Issue Addressed

Closes sigp#4185

## Proposed Changes

- Set user agent to `Lighthouse/vX.Y.Z-<commit hash>` by default
- Allow tweaking user agent via `--builder-user-agent "agent"`
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
@michaelsproul @Woodpile37
Set user agent on requests to builder (sigp#4199)
fd18a72 
## Issue Addressed

Closes sigp#4185

## Proposed Changes

- Set user agent to `Lighthouse/vX.Y.Z-<commit hash>` by default
- Allow tweaking user agent via `--builder-user-agent "agent"`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulhauner paulhauner paulhauner approved these changes

Assignees
No one assigned
Labels
builder API enhancement New feature or request low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-review The code is ready for review v4.1.0 Post-Capella minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelsproul @paulhauner