Remove snapshot cache related code #5661

jimmygchen · 2024-04-30T02:09:41Z

Issue Addressed

Some remaining review comments from #5533.

beacon_node/src/cli.rs

book/src/help_bn.md

beacon_node/beacon_chain/src/beacon_chain.rs

michaelsproul · 2024-04-30T07:06:49Z

Pushed some tests for the --state-cache flag as I realised we didn't have any.

michaelsproul · 2024-04-30T07:07:07Z

@Mergifyio queue

jimmygchen

Nice, thanks for adding the missing tests!

mergify · 2024-04-30T07:07:28Z

queue

🟠 Waiting for conditions to match

any of: [🔀 queue conditions]
- all of: [📌 queue conditions of queue default]
  - #approved-reviews-by >= 1
  - check-success=license/cla
  - check-success=target-branch-check
-draft [📌 queue requirement]
any of: [📌 queue -> configuration change requirements]
- -mergify-configuration-changed
- check-success=Configuration changed

Squashed commit of the following: commit 1378a62 Author: Michael Sproul <[email protected]> Date: Tue Apr 30 17:02:25 2024 +1000 Add state cache CLI tests commit 470134b Author: Michael Sproul <[email protected]> Date: Tue Apr 30 16:43:07 2024 +1000 Remove cache miss comment entirely commit 65eee99 Author: Michael Sproul <[email protected]> Date: Tue Apr 30 16:41:28 2024 +1000 Fix default state cache size in docs commit 64db49a Author: Jimmy Chen <[email protected]> Date: Tue Apr 30 11:51:10 2024 +1000 Remove snapshot cache and other references.

jimmygchen · 2024-04-30T08:45:15Z

Oh looks like it’s missing a green tick before it can be added to the merge queue!

realbigsean · 2024-04-30T15:39:08Z

@mergify queue

mergify · 2024-04-30T15:39:34Z

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 63fad7e

* Fix execution integration tests (#5647) * update waiting status * revert to old nethermind version * Add electra presets to beacon API (#5630) * add presets to API * add extra fields to config spec in beacon API * remove unused * add mainnet presets for gnosis and fix minimal preset default values * Rename `Merge` to `Bellatrix` (#5601) * Rename Merge to Bellatrix * Remove tree-hash-cache which got readded from the rebase * Deterministic block generation for tests (#5654) * Deterministic block generation for tests * Electra other containers (#5652) * add new fields to execution payload and header * beacon state changes * partial beacon state * safe arith in upgrade to electra * initialize balances cache in interop genesis state * Revert "initialize balances cache in interop genesis state" This reverts commit c60b522. * always initialize balances cache if necessary in electra upgrade * build cache earlier * fix block test * per fork NUM_FIELDS_POW2 * Merge branch 'unstable' of https://github.com/sigp/lighthouse into electra-other-containers * fix lints * get fields based on post state, as is spec'd * fix type and move cache build * Add more electra helpers (#5653) * Add new helpers * Fix some stuff * Fix compilation errors * lint * Address review * Ignore gossip blob already imported (#5656) * Ignore gossip blob already imported * Beta compiler fix (#5659) * fix beta compiler compilation * remove unused import * Revert "remove unused import" This reverts commit 0bef36b. * Revert "fix beta compiler compilation" This reverts commit 23152cf. * rename ununsed fields * allow dead code on some error variants * remove unused blob download queue * add back debug to backfill error * more allow dead code on errors * fix(validator_client): raise soft fd limit (#4796) * fix(validator_client): raise soft fd limit * Merge branch 'unstable' of https://github.com/sigp/lighthouse into rkrasiuk/raise-vc-fdlimit * cargo lock * Merge branch 'unstable' of https://github.com/sigp/lighthouse into rkrasiuk/raise-vc-fdlimit * Proposer and attester slashing sse events (#5327) * default vc to block v3 endpoint and deprecate block-v3 flag * Merge branch 'unstable' of https://github.com/sigp/lighthouse into unstable * add proposer and attester event variants * add TOOOs * add tests, event triggers * Merge branch 'unstable' of https://github.com/sigp/lighthouse into proposer-and-attester-slashing-sse-events * revert * revert * remove double event tracking * Merge branch 'unstable' into proposer-and-attester-slashing-sse-events * remove todo, fix test * resolve merge conflicts * Merge branch 'proposer-and-attester-slashing-sse-events' of https://github.com/eserilev/lighthouse into proposer-and-attester-slashing-sse-events * leftover debugging * Merge branch 'unstable' of https://github.com/sigp/lighthouse into proposer-and-attester-slashing-sse-events * Merge branch 'unstable' of https://github.com/sigp/lighthouse into proposer-and-attester-slashing-sse-events * pin macos release runner to `macos-13` (#5665) * pin macos release runner to `macos-13` * Update .github/workflows/release.yml * Remove snapshot cache related code (#5661) * Remove snapshot cache and other references. * Fix default state cache size in docs * Remove cache miss comment entirely * Add state cache CLI tests * Uncomment self_hosted_runner after PR Merge #5137 (#5291) * Uncomment self_hosted_runner after PR Merge #5137 * Merge branch 'unstable' into fix_todo * Merge branch 'unstable' of https://github.com/sigp/lighthouse into fix_todo * Only `portable` builds (binaries) (#5615) * release workflow: portable builds by default * Delete outdated comment * Merge branch 'unstable' into portable-builds-binaries # Conflicts: # .github/workflows/release.yml * Merge parent and current sync lookups (#5655) * Drop lookup type trait for a simple arg * Drop reconstructed for processing * Send parent blocks one by one * Merge current and parent lookups * Merge current and parent lookups clean up todos * Merge current and parent lookups tests * Merge remote-tracking branch 'origin/unstable' into sync-merged-lookup * Merge branch 'unstable' of https://github.com/sigp/lighthouse into sync-merged-lookup * fix compile after merge * #5655 pr review (#26) * fix compile after merge * remove todos, fix typos etc * fix compile * stable rng * delete TODO and unfilled out test * make download result a struct * enums instead of bools as params * fix comment * Various fixes * Track ignored child components * Track dropped lookup reason as metric * fix test * add comment describing behavior of avail check error * update ordering * delete spammy log (#5672) * delete spammy log * Ensure block only range requests don't fail on download (#5675) * ensure pruned blobs don't fail on download * Typo * Improve ENR updates (#5483) * Improve ENR updates * forever fmt * Appease my old friend clippy * Merge network unstable * Check da_checker before doing a block lookup request (#5681) * Check da_checker before doing a block lookup request * Ensure consistent handling of lookup result * use req resp pre import cache rather than da checker * Update Cargo.lock (#5670) * update rust-yamux * update Cargo.lock * Merge branch 'unstable' of github.com:jxs/lighthouse into update-cargo * Merge branch 'unstable' of github.com:sigp/lighthouse into update-cargo * update to new libp2p versions * Add metric for current epoch total balance (#5688) * Add metric for current epoch total balance --------- Co-authored-by: realbigsean <[email protected]> Co-authored-by: Mac L <[email protected]> Co-authored-by: Lion - dapplion <[email protected]> Co-authored-by: Pawan Dhananjay <[email protected]> Co-authored-by: Roman Krasiuk <[email protected]> Co-authored-by: Eitan Seri-Levi <[email protected]> Co-authored-by: antondlr <[email protected]> Co-authored-by: Jimmy Chen <[email protected]> Co-authored-by: Ærvin <[email protected]> Co-authored-by: Age Manning <[email protected]> Co-authored-by: João Oliveira <[email protected]> Co-authored-by: Michael Sproul <[email protected]>

Remove snapshot cache and other references.

64db49a

jimmygchen added v5.2.0 Q2 2024 ready-for-review The code is ready for review labels Apr 30, 2024

jimmygchen requested a review from michaelsproul April 30, 2024 02:11

michaelsproul reviewed Apr 30, 2024

View reviewed changes

beacon_node/src/cli.rs Outdated Show resolved Hide resolved

michaelsproul reviewed Apr 30, 2024

View reviewed changes

book/src/help_bn.md Outdated Show resolved Hide resolved

michaelsproul and others added 2 commits April 30, 2024 16:41

Fix default state cache size in docs

65eee99

Remove cache miss comment entirely

470134b

michaelsproul reviewed Apr 30, 2024

View reviewed changes

beacon_node/beacon_chain/src/beacon_chain.rs Show resolved Hide resolved

Add state cache CLI tests

1378a62

michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Apr 30, 2024

jimmygchen commented Apr 30, 2024

View reviewed changes

michaelsproul mentioned this pull request Apr 30, 2024

Release v5.2.0 #5664

Merged

realbigsean approved these changes Apr 30, 2024

View reviewed changes

mergify bot added a commit that referenced this pull request Apr 30, 2024

Merge of #5661

ae7c344

mergify bot mentioned this pull request Apr 30, 2024

merge queue: embarking unstable (d0602c3) and #5661 together #5668

Closed

5 tasks

mergify bot merged commit 63fad7e into sigp:unstable Apr 30, 2024
28 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove snapshot cache related code #5661

Remove snapshot cache related code #5661

jimmygchen commented Apr 30, 2024

michaelsproul commented Apr 30, 2024

michaelsproul commented Apr 30, 2024

jimmygchen left a comment

mergify bot commented Apr 30, 2024

jimmygchen commented Apr 30, 2024

realbigsean commented Apr 30, 2024

mergify bot commented Apr 30, 2024 •

edited

Loading

Remove snapshot cache related code #5661

Remove snapshot cache related code #5661

Conversation

jimmygchen commented Apr 30, 2024

Issue Addressed

michaelsproul commented Apr 30, 2024

michaelsproul commented Apr 30, 2024

jimmygchen left a comment

Choose a reason for hiding this comment

mergify bot commented Apr 30, 2024

🟠 Waiting for conditions to match

jimmygchen commented Apr 30, 2024

realbigsean commented Apr 30, 2024

mergify bot commented Apr 30, 2024 • edited Loading

✅ The pull request has been merged automatically

mergify bot commented Apr 30, 2024 •

edited

Loading