Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove snapshot cache related code #5661

Merged
merged 4 commits into from
Apr 30, 2024
Merged

Remove snapshot cache related code #5661

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
64db49a
Remove snapshot cache and other references.
jimmygchen Apr 30, 2024
65eee99
Fix default state cache size in docs
michaelsproul Apr 30, 2024
470134b
Remove cache miss comment entirely
michaelsproul Apr 30, 2024
1378a62
Add state cache CLI tests
michaelsproul Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion beacon_node/beacon_chain/src/beacon_chain.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4399,7 +4399,7 @@ impl<T: BeaconChainTypes> BeaconChain<T> {
} else {
info!(
self.log,
"Missed snapshot cache during withdrawals calculation";
"Missed state cache during withdrawals calculation";
"slot" => proposal_slot,
"parent_block_root" => ?parent_block_root
);
jimmygchen marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
9 changes: 1 addition & 8 deletions beacon_node/beacon_chain/src/metrics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,18 +32,11 @@ lazy_static! {
"beacon_block_processing_successes_total",
"Count of blocks processed without error"
);
// Keeping the existing "snapshot_cache" metric name as it would break existing dashboards
pub static ref BLOCK_PROCESSING_SNAPSHOT_CACHE_SIZE: Result<IntGauge> = try_create_int_gauge(
"beacon_block_processing_snapshot_cache_size",
"Count snapshots in the snapshot cache"
);
pub static ref BLOCK_PROCESSING_SNAPSHOT_CACHE_MISSES: Result<IntCounter> = try_create_int_counter(
"beacon_block_processing_snapshot_cache_misses",
"Count of snapshot cache misses"
);
pub static ref BLOCK_PROCESSING_SNAPSHOT_CACHE_CLONES: Result<IntCounter> = try_create_int_counter(
"beacon_block_processing_snapshot_cache_clones",
"Count of snapshot cache clones"
);
pub static ref BLOCK_PROCESSING_TIMES: Result<Histogram> =
try_create_histogram("beacon_block_processing_seconds", "Full runtime of block processing");
pub static ref BLOCK_PROCESSING_BLOCK_ROOT: Result<Histogram> = try_create_histogram(
Expand Down
Loading
Loading