-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename deploy_block in network config #5850
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@michaelsproul could use another review here before we merge just to be sure. I think this may break some testing tools, but that's probably it? |
I reckon good to go |
Looks like
I'm thinking it might be worth to just build |
PR to build |
…name-deply-block
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 6daeec3 |
Issue Addressed
eth-clients/holesky#104
Proposed Changes
Rename deploy_block.txt which was a Lighthouse specific config file to the agreed upon standard.
Additional Info
This shouldn't cause any backward incompatibility issues with built in network configs.
This would cause backwards incompatibility issues with older versions of lighthouse trying to load networks with just
deploy_block.txt
in the testnet-dir which isn't a big deal imo.