move path-related envs and constants to skywire for #1134 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Test ServiceConfAddress to skyenv constants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noting the recent changes to skywire develop branch, I really need path constants / envs / related functions to be in skywire. The services addresses can be defined here. Its constraining me from a broader rework of config gen to have these in a different repository.
I wasn't sure on the ports, or otherwise where to draw the line for certain things. So i left only the urls & addresses here and will restore the skyenv package files in skywire, omitting these constants.
I've added Default and Test ServiceConfAddress(es) to the skyenv constants in values.go
skywire.skycoin.com
skywire.dev
My PR#1132 will rely on this one